Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2868)

Unified Diff: ash/common/system/tray_accessibility.h

Issue 2343603003: [Chrome OS MD] Implement accessibility detailed view for the MD Ash system menu (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray_accessibility.h
diff --git a/ash/common/system/tray_accessibility.h b/ash/common/system/tray_accessibility.h
index 1c280e317a957554a19e5b9348fcde0a22812e23..801de13779fee6927e3f012798a350cef6dab8b4 100644
--- a/ash/common/system/tray_accessibility.h
+++ b/ash/common/system/tray_accessibility.h
@@ -21,6 +21,10 @@ namespace chromeos {
class TrayAccessibilityTest;
}
+namespace gfx {
+struct VectorIcon;
+}
+
namespace views {
class Button;
class ImageView;
@@ -48,6 +52,7 @@ class AccessibilityPopupView : public TrayNotificationView {
DISALLOW_COPY_AND_ASSIGN(AccessibilityPopupView);
};
+// Create the detailed view of accessibility tray.
class AccessibilityDetailedView : public TrayDetailsView,
public ShellObserver {
public:
@@ -63,12 +68,16 @@ class AccessibilityDetailedView : public TrayDetailsView,
// Add the accessibility feature list.
void AppendAccessibilityList();
- // Add help entries.
+ // Add help entries only used for non-MD. Note that the help entries row will
tdanderson 2016/09/21 17:59:33 nit: "Add help entries. Only used for non-MD."
yiyix 2016/09/21 19:02:27 Done.
+ // be integrated with the title row.
void AppendHelpEntries();
+ // Helper function to create entries in the detailed accessibility view. The
+ // |icon| parameter is used to create button icons for MD only.
HoverHighlightView* AddScrollListItem(const base::string16& text,
bool highlight,
- bool checked);
+ bool checked,
+ const gfx::VectorIcon& icon);
views::View* spoken_feedback_view_;
views::View* high_contrast_view_;

Powered by Google App Engine
This is Rietveld 408576698