[Chrome OS MD] Implement accessibility detailed view for the MD Ash system menu

ui/views/examples/throbber_example.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/examples/throbber_example.h"
 
 #include "base/macros.h"
 #include "ui/views/controls/throbber.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/view.h"
 
 namespace views {
 namespace examples {
 
 namespace {
 
 class ThrobberView : public View {
  public:
-  ThrobberView() : throbber_(new Throbber()) {
+  ThrobberView() : throbber_(new Throbber()), is_checked_(false) {
     AddChildView(throbber_);
     throbber_->Start();
   }
 
+  // View implementation.

[tdanderson, 2016/09/19 23:32:27]

nit: Just "// View:"

[yiyix, 2016/09/21 17:10:48]

Done.

   gfx::Size GetPreferredSize() const override {
     return gfx::Size(width(), height());
   }
 
   void Layout() override {
-    int diameter = 64;
+    int diameter = 16;
     throbber_->SetBounds((width() - diameter) / 2,
                          (height() - diameter) / 2,
                          diameter, diameter);
     SizeToPreferredSize();
   }
 
+  bool OnMousePressed(const ui::MouseEvent& event) override {
+    if (GetEventHandlerForPoint(event.location()) == throbber_) {
+      if (is_checked_) {
+        throbber_->Start();
+        throbber_->SetChecked(false);
+        is_checked_ = false;
+      } else {
+        throbber_->Stop();
+        throbber_->SetChecked(true);
+        is_checked_ = true;

[tdanderson, 2016/09/19 23:32:27]

You can avoid duplicated code with:

throbber->SetChecked(!is_checked_);
is_checked_ = !is_checked_;

[yiyix, 2016/09/21 17:10:48]

Thanks, I thought about it, then i don't know how to combine start() and stop()
in one line, so i give up.... sorry, i should combine as many line as possible.

+      }
+      return true;
+    }
+    return false;
+  }
+
  private:
   Throbber* throbber_;
+  bool is_checked_;
 
   DISALLOW_COPY_AND_ASSIGN(ThrobberView);
 };
 
 }  // namespace
 
 ThrobberExample::ThrobberExample() : ExampleBase("Throbber") {
 }
 
 ThrobberExample::~ThrobberExample() {
 }
 
 void ThrobberExample::CreateExampleView(View* container) {
   container->SetLayoutManager(new FillLayout());
   container->AddChildView(new ThrobberView());
 }
 
 }  // namespace examples
 }  // namespace views