Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: components/search_engines/template_url.cc

Issue 2343523002: [TTS] Request Now on Tap data in the Resolve request. (Closed)
Patch Set: Updated comments and rebased only. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url.cc
diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc
index a3be5cff8ebc067e03bc80fb10cf22c57bc3372d..8beb1ba93721185e9a79a4d8b1e79ba961f873c9 100644
--- a/components/search_engines/template_url.cc
+++ b/components/search_engines/template_url.cc
@@ -188,33 +188,29 @@ TemplateURLRef::SearchTermsArgs::ContextualSearchParams::
: version(-1),
start(base::string16::npos),
end(base::string16::npos),
- resolve(true) {
-}
+ now_on_tap_version(0) {}
-TemplateURLRef::SearchTermsArgs::ContextualSearchParams::
- ContextualSearchParams(
- const int version,
- const std::string& selection,
- const std::string& base_page_url,
- const bool resolve)
+TemplateURLRef::SearchTermsArgs::ContextualSearchParams::ContextualSearchParams(
+ const int version,
+ const std::string& selection,
+ const std::string& base_page_url,
+ const int now_on_tap_version)
: version(version),
start(base::string16::npos),
end(base::string16::npos),
selection(selection),
base_page_url(base_page_url),
- resolve(resolve) {
-}
+ now_on_tap_version(now_on_tap_version) {}
-TemplateURLRef::SearchTermsArgs::ContextualSearchParams::
- ContextualSearchParams(
- const int version,
- const size_t start,
- const size_t end,
- const std::string& selection,
- const std::string& content,
- const std::string& base_page_url,
- const std::string& encoding,
- const bool resolve)
+TemplateURLRef::SearchTermsArgs::ContextualSearchParams::ContextualSearchParams(
+ const int version,
+ const size_t start,
+ const size_t end,
+ const std::string& selection,
+ const std::string& content,
+ const std::string& base_page_url,
+ const std::string& encoding,
+ const int now_on_tap_version)
: version(version),
start(start),
end(end),
@@ -222,8 +218,7 @@ TemplateURLRef::SearchTermsArgs::ContextualSearchParams::
content(content),
base_page_url(base_page_url),
encoding(encoding),
- resolve(resolve) {
-}
+ now_on_tap_version(now_on_tap_version) {}
TemplateURLRef::SearchTermsArgs::ContextualSearchParams::ContextualSearchParams(
const ContextualSearchParams& other) = default;
@@ -1020,8 +1015,11 @@ std::string TemplateURLRef::HandleReplacements(
context_data.append("ctxs_encoding=" + params.encoding + "&");
}
- context_data.append(
- params.resolve ? "ctxsl_resolve=1" : "ctxsl_resolve=0");
+ // The above parameters all add a trailing "&" so there must be one last
+ // parameter that's always added at the end.
+ std::string now_on_tap_version(
+ base::IntToString(params.now_on_tap_version));
Peter Kasting 2016/09/15 23:05:41 Nit: I'd probably just inline this into the next s
Donn Denman 2016/09/15 23:34:25 Done.
+ context_data.append("ctxsl_coca=" + now_on_tap_version);
HandleReplacement(std::string(), context_data, *i, &url);
break;

Powered by Google App Engine
This is Rietveld 408576698