DNS probes: several tweaks to error page updating

chrome/renderer/resources/neterror.js

Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 2dd8934698c204eb01e3e2a8948fec5c642e7165..c108535d4c38589dec20551307d8285d8bab6950 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -28,9 +28,15 @@ if (window.top.location != window.location)
   document.documentElement.setAttribute('subframe', '');
 
 function updateForDnsProbe(strings) {
+  i18nTemplate.process(document, strings);
   var context = new JsEvalContext(strings);
-  jstProcess(context, document.getElementById('help-box-outer'));
-  jstProcess(context, document.getElementById('details'));
+  jstProcess(context, document.getElementById('t'));
+}
+
+function updateIconClass(classList, newClass) {
+  classList.remove('icon-generic');
+  classList.remove('icon-offline');
+  classList.add(newClass);

[mmenke, 2013/08/26 19:34:42]

I wonder about this scaling.  Not too bad with two classes, but if there were 5,
or 5-dozen...  Also seems like it's very likely to regress when more classes are
added.

[Deprecated (see juliatuttle), 2013/08/26 20:24:40]

Agreed.  If it got to be more than two or three, I'd stuff the previous class
somewhere and remove just it.

[Deprecated (see juliatuttle), 2013/08/26 21:44:17]

Alright, fixed.  It now stashes the last name in a property "last_icon_class" of
the classList.  It's ugly, but it works.

 }
 
 <if expr="is_macosx or is_ios or is_linux or is_android">