Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 23434002: DNS probes: several tweaks to error page updating (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remember and remove old icon class instead of removing all of them Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 2dd8934698c204eb01e3e2a8948fec5c642e7165..b9e9fec1b25ed0df6add80e36e009da11bd61ba4 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -28,9 +28,17 @@ if (window.top.location != window.location)
document.documentElement.setAttribute('subframe', '');
function updateForDnsProbe(strings) {
James Hawkins 2013/08/27 18:07:15 nit: Document methods and params.
+ i18nTemplate.process(document, strings);
var context = new JsEvalContext(strings);
- jstProcess(context, document.getElementById('help-box-outer'));
- jstProcess(context, document.getElementById('details'));
+ jstProcess(context, document.getElementById('t'));
+}
+
+function updateIconClass(classList, newClass) {
+ classList.add(newClass);
+
+ if (classList.hasOwnProperty('last_icon_class'))
+ classList.remove(classList['last_icon_class']);
+ classList['last_icon_class'] = newClass;
}
<if expr="is_macosx or is_ios or is_linux or is_android">
« chrome/renderer/resources/neterror.html ('K') | « chrome/renderer/resources/neterror.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698