DNS probes: several tweaks to error page updating

chrome/renderer/resources/neterror.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function toggleHelpBox() {
   var helpBoxOuter = document.getElementById('help-box-outer');
   helpBoxOuter.classList.toggle('hidden');
   var moreLessButton = document.getElementById('more-less-button');
   if (helpBoxOuter.classList.contains('hidden')) {
     moreLessButton.innerText = moreLessButton.moreText;
@@ skipping 10 matching lines @@
       '/index.html"></iframe>';
 }
 
 // Subframes use a different layout but the same html file.  This is to make it
 // easier to support platforms that load the error page via different
 // mechanisms (Currently just iOS).
 if (window.top.location != window.location)
   document.documentElement.setAttribute('subframe', '');
 
 function updateForDnsProbe(strings) {
+  i18nTemplate.process(document, strings);
   var context = new JsEvalContext(strings);
-  jstProcess(context, document.getElementById('help-box-outer'));
-  jstProcess(context, document.getElementById('details'));
+  jstProcess(context, document.getElementById('t'));
+}
+
+function updateIconClass(classList, newClass) {
+  classList.remove('icon-generic');
+  classList.remove('icon-offline');
+  classList.add(newClass);

[mmenke, 2013/08/26 19:34:42]

I wonder about this scaling.  Not too bad with two classes, but if there were 5,
or 5-dozen...  Also seems like it's very likely to regress when more classes are
added.

[Deprecated (see juliatuttle), 2013/08/26 20:24:40]

Agreed.  If it got to be more than two or three, I'd stuff the previous class
somewhere and remove just it.

[Deprecated (see juliatuttle), 2013/08/26 21:44:17]

Alright, fixed.  It now stashes the last name in a property "last_icon_class" of
the classList.  It's ugly, but it works.

 }
 
 <if expr="is_macosx or is_ios or is_linux or is_android">
 // Re-orders buttons. Used on Mac, Linux, and Android, where reload should go
 // on the right.
 function swapButtonOrder() {
   reloadButton = document.getElementById('reload-button');
   moreLessButton = document.getElementById('more-less-button');
   reloadButton.parentNode.insertBefore(moreLessButton, reloadButton);
 }
 document.addEventListener("DOMContentLoaded", swapButtonOrder);
 </if>