chrome/renderer/resources/neterror.html - Issue 23434002: DNS probes: several tweaks to error page updating

Side by Side Diff: chrome/renderer/resources/neterror.html

Issue 23434002: DNS probes: several tweaks to error page updating (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remember and remove old icon class instead of removing all of them Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta name="viewport" content="width=device-width, initial-scale=1.0,	4 <meta name="viewport" content="width=device-width, initial-scale=1.0,

5 maximum-scale=1.0, user-scalable=no">	5 maximum-scale=1.0, user-scalable=no">

6 <title i18n-content="title"></title>	6 <title i18n-content="title"></title>

7 <link rel="stylesheet" href="neterror.css">	7 <link rel="stylesheet" href="neterror.css">

8 <script src="neterror.js"></script>	8 <script src="neterror.js"></script>

9 </head>	9 </head>

10	10

11 <body id="t">	11 <body id="t">

12 <div id="main-frame-error">	12 <div id="main-frame-error">

13 <div id="box">	13 <div id="box">

14 <div id="content-top">	14 <div id="content-top">

15 <h1>	15 <h1>

16 <div><img class="icon" jseval="this.classList.add(iconClass)"></div>	16 <div>

	17 <img class="icon" jseval="updateIconClass(this.classList, iconClass)">
	James Hawkins 2013/08/27 18:07:15 nit: Missing one more space of indentation. nit: Missing one more space of indentation.
	18 </div>

17 <span i18n-content="heading"></span>	19 <span i18n-content="heading"></span>

18 </h1>	20 </h1>

19	21

20 <button id="reload-button" onclick="location = this.url" jsselect="reload" j svalues=".url:reloadUrl" jscontent="msg"></button>	22 <button id="reload-button" onclick="location = this.url" jsselect="reload" j svalues=".url:reloadUrl" jscontent="msg"></button>

21 <button id="more-less-button" onclick="toggleHelpBox()" jsdisplay="more" jsv alues=".moreText:more; .lessText:less;" jscontent="more"></button>	23 <button id="more-less-button" onclick="toggleHelpBox()" jsdisplay="more" jsv alues=".moreText:more; .lessText:less;" jscontent="more"></button>

22 </div>	24 </div>

23	25

24 <!-- Outer and inner divs are needed both for margins and sizing. -->	26 <!-- Outer and inner divs are needed both for margins and sizing. -->

25 <div id="help-box-outer" class="hidden">	27 <div id="help-box-outer" class="hidden">

26 <div id="help-box-inner">	28 <div id="help-box-inner">

27 <div jsselect="summary">	29 <div jsselect="summary">

28 <span jsvalues=".innerHTML:msg"></span>	30 <span jsvalues=".innerHTML:msg"></span>

29 </div>	31 </div>

30	32

31 <div class="suggestions" jsselect="suggestions">	33 <div class="suggestions" jsselect="suggestions">

32 <div class="suggestion-header" jsvalues=".innerHTML:header"></div>	34 <div class="suggestion-header" jsvalues=".innerHTML:header"></div>

33 <div class="suggestion-body" jsvalues=".innerHTML:body"></div>	35 <div class="suggestion-body" jsvalues=".innerHTML:body"></div>

34 </div>	36 </div>

35 <button id="diagnose-button" onclick="diagnoseErrors()"	37 <button id="diagnose-button" onclick="diagnoseErrors()"

36 jscontent="diagnose" jsdisplay="diagnose"></button>	38 jscontent="diagnose" jsdisplay="diagnose"></button>

37 <div id="diagnose-frame" class="hidden"></div>	39 <div id="diagnose-frame" class="hidden"></div>

38 <div class="error-code" jscontent="errorCode"></div>	40 <div class="error-code" jscontent="errorCode"></div>

39 </div>	41 </div>

40 </div>	42 </div>

41 </div>	43 </div>

42 </div>	44 </div>

43 <div id="sub-frame-error">	45 <div id="sub-frame-error">

44 <!-- Show details when hovering over the icon, in case the details are	46 <!-- Show details when hovering over the icon, in case the details are

45 hidden because they're too large. -->	47 hidden because they're too large. -->

46 <img class="icon" jseval="this.classList.add(iconClass)" jsvalues=".title:erro rDetails">	48 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"

	49 jsvalues=".title:errorDetails">
	James Hawkins 2013/08/27 18:07:15 nit: 4 space indentation required for wrapped line nit: 4 space indentation required for wrapped lines.
47 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>	50 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>

48 </div>	51 </div>

49 </body>	52 </body>

50 </html>	53 </html>

OLD	NEW

« chrome/common/localized_error.cc ('K') | « chrome/common/localized_error.cc ('k') | chrome/renderer/resources/neterror.js » ('j') | chrome/renderer/resources/neterror.js » ('J')