Issue 23432010: Android: Don't restart/reboot on package install failure

Issue 23432010: Android: Don't restart/reboot on package install failure (Closed)

Created:
7 years, 3 months ago by no sievers

Modified:
7 years, 3 months ago

Reviewers:
frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Don't restart/reboot on package install failure In the scripts used by the test runners only restart the shell or reboot the device if there was a timeout. Otherwise print the error and abort. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222466

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
		build/android/pylib/android_commands.py	View	1	4 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm w/ nits. Thanks! https://codereview.chromium.org/23432010/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23432010/diff/1/build/android/pylib/android_commands.py#newcode443 build/android/pylib/android_commands.py:443: raise Exception('Install failure: ' + ...

7 years, 3 months ago (2013-09-10 22:29:10 UTC) #2

no sievers

https://codereview.chromium.org/23432010/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23432010/diff/1/build/android/pylib/android_commands.py#newcode443 build/android/pylib/android_commands.py:443: raise Exception('Install failure: ' + install_status) On 2013/09/10 22:29:11, ...

7 years, 3 months ago (2013-09-11 00:21:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/23432010/9001

7 years, 3 months ago (2013-09-11 00:24:11 UTC) #4

Message was sent while issue was closed.

Change committed as 222466

Expand Messages | Collapse Messages