chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc - Issue 23432006: [Activity log] Strip incognito URLs entirely from the database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

Issue 23432006: [Activity log] Strip incognito URLs entirely from the database (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

index 7b0e07858aa9b835689ade95254c2a73e9d9a167..9ad74ae0ea7f02f84f310c089ecad28094411fa9 100644

--- a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

@@ -32,7 +32,7 @@ TEST_F(ActivityLogPolicyUtilTest, StripPrivacySensitive) {

ActivityLogPolicy::Util::StripPrivacySensitiveFields(action);

ASSERT_FALSE(action->page_url().is_valid());

- ASSERT_EQ("<incognito>", action->SerializePageUrl());

+ ASSERT_EQ("", action->SerializePageUrl());

ASSERT_EQ("", action->page_title());

ASSERT_EQ("http://www.youtube.com/", action->arg_url().spec());

}

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_policy.cc ('k') | no next file » | no next file with comments »