Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: scripts/slave/recipes/android/android_builder.expected/klp_builder.json

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android/android_builder.expected/klp_builder.json
diff --git a/scripts/slave/recipes/android/android_builder.expected/klp_builder.json b/scripts/slave/recipes/android/android_builder.expected/klp_builder.json
index bcdfbcbd3032f4d820dceb8abb58c4c641d8f392..a7ca4ace5e2e65d97e986bf96ce4a98d6ff07bf9 100644
--- a/scripts/slave/recipes/android/android_builder.expected/klp_builder.json
+++ b/scripts/slave/recipes/android/android_builder.expected/klp_builder.json
@@ -47,7 +47,7 @@
"--output-json",
"/path/to/tmp/json"
],
- "name": "Get AppManifestVars",
+ "name": "get app_manifest_vars",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@",
@@ -69,11 +69,13 @@
"ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
"ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_internal/sdk",
"ANDROID_SDK_VERSION": "KeyLimePie",
- "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_landmines.py"
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:"
},
"name": "envsetup",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"GYP_DEFINES\": \"my_new_gyp_def=aaa\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"GYP_SOMETHING\": \"gyp_something_value\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
@@ -110,7 +112,7 @@
"src-internal",
"src/repo"
],
- "name": "Tree Truth Steps"
+ "name": "tree truth steps"
},
{
"cmd": [
@@ -120,7 +122,11 @@
"runhooks"
],
"env": {
- "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
+ "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
+ "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_internal/sdk",
+ "ANDROID_SDK_VERSION": "KeyLimePie",
+ "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_landmines.py",
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
},
"name": "gclient runhooks"
},
@@ -143,7 +149,10 @@
"All"
],
"env": {
- "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
+ "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
+ "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_internal/sdk",
+ "ANDROID_SDK_VERSION": "KeyLimePie",
+ "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
},
"name": "compile"
}

Powered by Google App Engine
This is Rietveld 408576698