Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: scripts/slave/recipes/android/android_builder.expected/x86_builder.json

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « scripts/slave/recipes/android/android_builder.expected/try_builder.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "[DEPOT_TOOLS_ROOT]/gclient.py", 6 "[DEPOT_TOOLS_ROOT]/gclient.py",
7 "config", 7 "config",
8 "--spec", 8 "--spec",
9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']" 9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']"
10 ], 10 ],
(...skipping 29 matching lines...) Expand all
40 { 40 {
41 "cmd": [ 41 "cmd": [
42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py", 42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py",
43 "-b", 43 "-b",
44 "builder_name", 44 "builder_name",
45 "-v", 45 "-v",
46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION", 46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION",
47 "--output-json", 47 "--output-json",
48 "/path/to/tmp/json" 48 "/path/to/tmp/json"
49 ], 49 ],
50 "name": "Get AppManifestVars", 50 "name": "get app_manifest_vars",
51 "~followup_annotations": [ 51 "~followup_annotations": [
52 "@@@STEP_LOG_LINE@json.output@{@@@", 52 "@@@STEP_LOG_LINE@json.output@{@@@",
53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@", 53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@",
54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@", 54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@",
55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@", 55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@",
56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some builder 1234\"@@@ ", 56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some_builder_1234\"@@@ ",
57 "@@@STEP_LOG_LINE@json.output@}@@@", 57 "@@@STEP_LOG_LINE@json.output@}@@@",
58 "@@@STEP_LOG_END@json.output@@@" 58 "@@@STEP_LOG_END@json.output@@@"
59 ] 59 ]
60 }, 60 },
61 { 61 {
62 "cmd": [ 62 "cmd": [
63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py", 63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py",
64 "--output-json", 64 "--output-json",
65 "/path/to/tmp/json", 65 "/path/to/tmp/json",
66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh", 66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh",
67 "--target-arch=x86" 67 "--target-arch=x86"
68 ], 68 ],
69 "env": { 69 "env": {
70 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py" 70 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:"
71 }, 71 },
72 "name": "envsetup", 72 "name": "envsetup",
73 "~followup_annotations": [ 73 "~followup_annotations": [
74 "@@@STEP_LOG_LINE@json.output@{@@@", 74 "@@@STEP_LOG_LINE@json.output@{@@@",
75 "@@@STEP_LOG_LINE@json.output@ \"GYP_DEFINES\": \"my_new_gyp_def=aaa\", @ @@",
76 "@@@STEP_LOG_LINE@json.output@ \"GYP_SOMETHING\": \"gyp_something_value\" , @@@",
75 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@", 77 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@",
76 "@@@STEP_LOG_LINE@json.output@}@@@", 78 "@@@STEP_LOG_LINE@json.output@}@@@",
77 "@@@STEP_LOG_END@json.output@@@" 79 "@@@STEP_LOG_END@json.output@@@"
78 ] 80 ]
79 }, 81 },
80 { 82 {
81 "cmd": [ 83 "cmd": [
82 "python", 84 "python",
83 "-u", 85 "-u",
84 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n", 86 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n",
(...skipping 16 matching lines...) Expand all
101 }, 103 },
102 { 104 {
103 "allow_subannottations": true, 105 "allow_subannottations": true,
104 "cmd": [ 106 "cmd": [
105 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh", 107 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh",
106 "[SLAVE_BUILD_ROOT]/src", 108 "[SLAVE_BUILD_ROOT]/src",
107 "src", 109 "src",
108 "src-internal", 110 "src-internal",
109 "src/repo" 111 "src/repo"
110 ], 112 ],
111 "name": "Tree Truth Steps" 113 "name": "tree truth steps"
112 }, 114 },
113 { 115 {
114 "cmd": [ 116 "cmd": [
115 "python", 117 "python",
116 "-u", 118 "-u",
117 "[DEPOT_TOOLS_ROOT]/gclient.py", 119 "[DEPOT_TOOLS_ROOT]/gclient.py",
118 "runhooks" 120 "runhooks"
119 ], 121 ],
120 "env": { 122 "env": {
121 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 123 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py",
124 "GYP_CROSSCOMPILE": 1,
125 "GYP_DEFINES": "OS=android app_manifest_version_code=10 app_manifest_versi on_name=some_builder_1234 chrome_build_id=3333 component=shared_library fastbuil d=1 gcc_version=46 host_os=linux order_text_section=[SLAVE_BUILD_ROOT]/src/order files/orderfile.out target_arch=arm",
126 "GYP_GENERATORS": "ninja",
127 "GYP_GENERATOR_FLAGS": "default_target=All",
128 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
122 }, 129 },
123 "name": "gclient runhooks" 130 "name": "gclient runhooks"
124 }, 131 },
125 { 132 {
126 "cmd": [ 133 "cmd": [
127 "python", 134 "python",
128 "-u", 135 "-u",
129 "[BUILD_ROOT]/scripts/slave/compile.py", 136 "[BUILD_ROOT]/scripts/slave/compile.py",
130 "--target", 137 "--target",
131 "Debug", 138 "Debug",
132 "--build-dir", 139 "--build-dir",
133 "[SLAVE_BUILD_ROOT]/src/out", 140 "[SLAVE_BUILD_ROOT]/src/out",
134 "--src-dir", 141 "--src-dir",
135 "[SLAVE_BUILD_ROOT]/src", 142 "[SLAVE_BUILD_ROOT]/src",
136 "--build-tool", 143 "--build-tool",
137 "ninja", 144 "ninja",
138 "--compiler", 145 "--compiler",
139 "goma", 146 "goma",
140 "--", 147 "--",
141 "All" 148 "All"
142 ], 149 ],
143 "env": { 150 "env": {
144 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 151 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
145 }, 152 },
146 "name": "compile" 153 "name": "compile"
147 } 154 }
148 ] 155 ]
OLDNEW
« no previous file with comments | « scripts/slave/recipes/android/android_builder.expected/try_builder.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698