Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: scripts/slave/recipes/android/android_builder.expected/klp_builder.json

Issue 23431038: [chromium_android recipes] Cleanup envsetup step and cleanup step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "[DEPOT_TOOLS_ROOT]/gclient.py", 6 "[DEPOT_TOOLS_ROOT]/gclient.py",
7 "config", 7 "config",
8 "--spec", 8 "--spec",
9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']" 9 "cache_dir = None\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True , 'name': 'src/repo', 'url': 'svn://svn.chromium.org/chrome/trunk/src'}]\ntarget _os = ['android']"
10 ], 10 ],
(...skipping 29 matching lines...) Expand all
40 { 40 {
41 "cmd": [ 41 "cmd": [
42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py", 42 "[SLAVE_BUILD_ROOT]/src/repo/build/dump_app_manifest_vars.py",
43 "-b", 43 "-b",
44 "builder_name", 44 "builder_name",
45 "-v", 45 "-v",
46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION", 46 "[SLAVE_BUILD_ROOT]/src/chrome/VERSION",
47 "--output-json", 47 "--output-json",
48 "/path/to/tmp/json" 48 "/path/to/tmp/json"
49 ], 49 ],
50 "name": "Get AppManifestVars", 50 "name": "get app_manifest_vars",
51 "~followup_annotations": [ 51 "~followup_annotations": [
52 "@@@STEP_LOG_LINE@json.output@{@@@", 52 "@@@STEP_LOG_LINE@json.output@{@@@",
53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@", 53 "@@@STEP_LOG_LINE@json.output@ \"build_id\": 3333, @@@",
54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@", 54 "@@@STEP_LOG_LINE@json.output@ \"date_string\": 6001, @@@",
55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@", 55 "@@@STEP_LOG_LINE@json.output@ \"version_code\": 10, @@@",
56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some builder 1234\"@@@ ", 56 "@@@STEP_LOG_LINE@json.output@ \"version_name\": \"some_builder_1234\"@@@ ",
57 "@@@STEP_LOG_LINE@json.output@}@@@", 57 "@@@STEP_LOG_LINE@json.output@}@@@",
58 "@@@STEP_LOG_END@json.output@@@" 58 "@@@STEP_LOG_END@json.output@@@"
59 ] 59 ]
60 }, 60 },
61 { 61 {
62 "cmd": [ 62 "cmd": [
63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py", 63 "[SLAVE_BUILD_ROOT]/src/build/env_dump.py",
64 "--output-json", 64 "--output-json",
65 "/path/to/tmp/json", 65 "/path/to/tmp/json",
66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh" 66 "[SLAVE_BUILD_ROOT]/src/build/android/envsetup.sh"
67 ], 67 ],
68 "env": { 68 "env": {
69 "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie", 69 "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
70 "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_inte rnal/sdk", 70 "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_inte rnal/sdk",
71 "ANDROID_SDK_VERSION": "KeyLimePie", 71 "ANDROID_SDK_VERSION": "KeyLimePie",
72 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py" 72 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:"
73 }, 73 },
74 "name": "envsetup", 74 "name": "envsetup",
75 "~followup_annotations": [ 75 "~followup_annotations": [
76 "@@@STEP_LOG_LINE@json.output@{@@@", 76 "@@@STEP_LOG_LINE@json.output@{@@@",
77 "@@@STEP_LOG_LINE@json.output@ \"GYP_DEFINES\": \"my_new_gyp_def=aaa\", @ @@",
78 "@@@STEP_LOG_LINE@json.output@ \"GYP_SOMETHING\": \"gyp_something_value\" , @@@",
77 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@", 79 "@@@STEP_LOG_LINE@json.output@ \"PATH\": \"./\"@@@",
78 "@@@STEP_LOG_LINE@json.output@}@@@", 80 "@@@STEP_LOG_LINE@json.output@}@@@",
79 "@@@STEP_LOG_END@json.output@@@" 81 "@@@STEP_LOG_END@json.output@@@"
80 ] 82 ]
81 }, 83 },
82 { 84 {
83 "cmd": [ 85 "cmd": [
84 "python", 86 "python",
85 "-u", 87 "-u",
86 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n", 88 "\nimport shutil, sys, os\nshutil.rmtree(sys.argv[1], True)\nshutil.rmtree (sys.argv[2], True)\nfor base, _dirs, files in os.walk(sys.argv[3]):\n for f in files:\n if f.endswith('.pyc'):\n os.remove(os.path.join(base, f))\n",
(...skipping 16 matching lines...) Expand all
103 }, 105 },
104 { 106 {
105 "allow_subannottations": true, 107 "allow_subannottations": true,
106 "cmd": [ 108 "cmd": [
107 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh", 109 "[SLAVE_BUILD_ROOT]/src/build/tree_truth.sh",
108 "[SLAVE_BUILD_ROOT]/src", 110 "[SLAVE_BUILD_ROOT]/src",
109 "src", 111 "src",
110 "src-internal", 112 "src-internal",
111 "src/repo" 113 "src/repo"
112 ], 114 ],
113 "name": "Tree Truth Steps" 115 "name": "tree truth steps"
114 }, 116 },
115 { 117 {
116 "cmd": [ 118 "cmd": [
117 "python", 119 "python",
118 "-u", 120 "-u",
119 "[DEPOT_TOOLS_ROOT]/gclient.py", 121 "[DEPOT_TOOLS_ROOT]/gclient.py",
120 "runhooks" 122 "runhooks"
121 ], 123 ],
122 "env": { 124 "env": {
123 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 125 "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
126 "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_inte rnal/sdk",
127 "ANDROID_SDK_VERSION": "KeyLimePie",
128 "EXTRA_LANDMINES_SCRIPT": "[SLAVE_BUILD_ROOT]/src/repo/build/get_internal_ landmines.py",
129 "GYP_CROSSCOMPILE": 1,
130 "GYP_DEFINES": "OS=android app_manifest_version_code=10 app_manifest_versi on_name=some_builder_1234 chrome_build_id=3333 component=shared_library fastbuil d=1 gcc_version=46 host_os=linux order_text_section=[SLAVE_BUILD_ROOT]/src/order files/orderfile.out target_arch=arm",
131 "GYP_GENERATORS": "ninja",
132 "GYP_GENERATOR_FLAGS": "default_target=All",
133 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
124 }, 134 },
125 "name": "gclient runhooks" 135 "name": "gclient runhooks"
126 }, 136 },
127 { 137 {
128 "cmd": [ 138 "cmd": [
129 "python", 139 "python",
130 "-u", 140 "-u",
131 "[BUILD_ROOT]/scripts/slave/compile.py", 141 "[BUILD_ROOT]/scripts/slave/compile.py",
132 "--target", 142 "--target",
133 "Debug", 143 "Debug",
134 "--build-dir", 144 "--build-dir",
135 "[SLAVE_BUILD_ROOT]/src/out", 145 "[SLAVE_BUILD_ROOT]/src/out",
136 "--src-dir", 146 "--src-dir",
137 "[SLAVE_BUILD_ROOT]/src", 147 "[SLAVE_BUILD_ROOT]/src",
138 "--build-tool", 148 "--build-tool",
139 "ninja", 149 "ninja",
140 "--compiler", 150 "--compiler",
141 "goma", 151 "goma",
142 "--", 152 "--",
143 "All" 153 "All"
144 ], 154 ],
145 "env": { 155 "env": {
146 "PATH": "./[BUILD_INTERNAL_ROOT]/scripts/slave/android:./" 156 "ANDROID_SDK_BUILD_TOOLS_VERSION": "android-KeyLimePie",
157 "ANDROID_SDK_ROOT": "[SLAVE_BUILD_ROOT]/src/third_party/android_tools_inte rnal/sdk",
158 "ANDROID_SDK_VERSION": "KeyLimePie",
159 "PATH": "[BUILD_INTERNAL_ROOT]/scripts/slave/android:./"
147 }, 160 },
148 "name": "compile" 161 "name": "compile"
149 } 162 }
150 ] 163 ]
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698