ui/gfx/vector_icons/network_badge_add_other.icon - Issue 2342793005: [ash-md] Adds Wi-Fi header row to system tray network detailed view

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/vector_icons/network_badge_add_other.icon

Issue 2342793005: [ash-md] Adds Wi-Fi header row to system tray network detailed view (Closed)

Patch Set: [ash-md] Materializes system tray network detailed view Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 CANVAS_DIMENSIONS, 12,	5 CANVAS_DIMENSIONS, 16,
	varkha 2016/09/19 20:19:23 I thought that if I make this larger the badge wil I thought that if I make this larger the badge will be allowed to overlap the main icon but it seems to be getting scaled into the same corner space. Is there a way to specify the absolute size of the badge here? Evan Stade 2016/09/19 20:40:47 I'm not sure what you're seeing. Can you post scre Show quoted text On 2016/09/19 20:19:23, varkha wrote: > I thought that if I make this larger the badge will be allowed to overlap the > main icon but it seems to be getting scaled into the same corner space. Is there > a way to specify the absolute size of the badge here? I'm not sure what you're seeing. Can you post screenshots? This is the code that places the badge. It shouldn't be doing any scaling: https://cs.chromium.org/chromium/src/ui/chromeos/network/network_icon.cc?rcl=... varkha 2016/09/23 00:35:53 Yes, your offline suggestion helped. The real size Show quoted text On 2016/09/19 20:40:47, Evan Stade wrote: > On 2016/09/19 20:19:23, varkha wrote: > > I thought that if I make this larger the badge will be allowed to overlap the > > main icon but it seems to be getting scaled into the same corner space. Is > there > > a way to specify the absolute size of the badge here? > > I'm not sure what you're seeing. Can you post screenshots? This is the code that > places the badge. It shouldn't be doing any scaling: > > https://cs.chromium.org/chromium/src/ui/chromeos/network/network_icon.cc?rcl=... Yes, your offline suggestion helped. The real size is set in a 1x icon.
6 MOVE_TO, 11, 8,	6 PATH_COLOR_ARGB, 0xFF, 0x42, 0x85, 0xF4,

7 H_LINE_TO, 4,	7 MOVE_TO, 7, 1,

	8 R_H_LINE_TO, 3,

	9 R_V_LINE_TO, 16,

	10 R_H_LINE_TO, -3,

8 V_LINE_TO, 1,	11 V_LINE_TO, 1,

9 R_H_LINE_TO, 7,

10 R_V_LINE_TO, 7,

11 CLOSE,	12 CLOSE,

12 MOVE_TO, 6, 6,	13 MOVE_TO, 1, 7,

13 V_LINE_TO, 3,	14 R_H_LINE_TO, 16,

	15 R_V_LINE_TO, 3,

	16 H_LINE_TO, 1,

	17 R_V_LINE_TO, -3,

	18 CLOSE,

	19 MOVE_TO, 7, 7,

14 R_H_LINE_TO, 3,	20 R_H_LINE_TO, 3,

15 R_V_LINE_TO, 3,	21 R_V_LINE_TO, 3,

16 H_LINE_TO, 6,	22 R_H_LINE_TO, -3,

17 CLOSE,	23 R_V_LINE_TO, -3,

18 MOVE_TO, 3, 3,

19 H_LINE_TO, 1,

20 R_V_LINE_TO, 8,

21 R_H_LINE_TO, 8,

22 V_LINE_TO, 9,

23 H_LINE_TO, 3,

24 V_LINE_TO, 3,

25 CLOSE,	24 CLOSE,

26 END	25 END

OLD	NEW

« ui/chromeos/network/network_list_md.cc ('K') | « ui/gfx/vector_icons/BUILD.gn ('k') | ui/gfx/vector_icons/network_badge_add_other.1x.icon » ('j') | no next file with comments »