service/datastore/size_test.go - Issue 2342063003: Differentiate between single- and multi- props.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/size_test.go

Issue 2342063003: Differentiate between single- and multi- props. (Closed)

Patch Set: Slice is now always a clone. This is marginally worse performance, but a much safer UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/size_test.go

diff --git a/service/datastore/size_test.go b/service/datastore/size_test.go

index e07cbac73fe2c5aabe6ad323c42958726c66cf20..817f2b1ef9808928f7cf03f10f4a03c24c00b900 100644

--- a/service/datastore/size_test.go

+++ b/service/datastore/size_test.go

@@ -27,7 +27,7 @@ var estimateSizeTests = []struct {

pm PropertyMap

expect int

}{

- {PropertyMap{"Something": {}}, 9},

+ {PropertyMap{"Something": mps()}, 9},

{PropertyMap{"Something": mps(100)}, 18},

{PropertyMap{"Something": mps(100.1, "sup")}, 22},

{PropertyMap{

@@ -56,7 +56,7 @@ func stablePmString(pm PropertyMap) string {

if i != 0 {

_, _ = buf.WriteString(" ")

}

- vals := pm[k]

+ vals := pm.Slice(k)

strs := make([]string, len(vals))

for i, v := range vals {

strs[i] = v.GQL()

« no previous file with comments | « service/datastore/serialize/serialize_test.go ('k') | no next file » | no next file with comments »