filter/txnBuf/query_merger.go - Issue 2342063003: Differentiate between single- and multi- props.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/txnBuf/query_merger.go

Issue 2342063003: Differentiate between single- and multi- props. (Closed)

Patch Set: Slice is now always a clone. This is marginally worse performance, but a much safer UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: filter/txnBuf/query_merger.go

diff --git a/filter/txnBuf/query_merger.go b/filter/txnBuf/query_merger.go

index 524b5a9e042e2b2c0e2f1fd37c3a86e60b646b01..3a0c30485f03d2e68ab8849f8c28ae09792c2bb3 100644

--- a/filter/txnBuf/query_merger.go

+++ b/filter/txnBuf/query_merger.go

@@ -262,8 +262,8 @@ func toComparableString(start, end []byte, order []ds.IndexColumn, k *ds.Key, pm

for _, ord := range order {

row, ok := ps[ord.Property]

if !ok {

- if vals, ok := pm[ord.Property]; ok {

- row = serialize.PropertySlice(vals)

+ if pslice := pm.Slice(ord.Property); len(pslice) > 0 {

+ row = serialize.PropertySlice(pslice)

}

sort.Sort(row)

« no previous file with comments | « filter/featureBreaker/featurebreaker_test.go ('k') | filter/txnBuf/txnbuf_test.go » ('j') | no next file with comments »