Add content::RenderWidgetHost::MouseEventCallback

Add content::RenderWidgetHost::MouseEventCallback

This adds the possibility to register mouse event callbacks with
RenderWidgetHost and get notified about all kinds of mouse events.  Any
callback can "handle" the event, in which case it's not propagated to the
renderer.

Opera registers a mouse event callback to feed its mouse gesture recognizer
with events.  At this point, there is no other implementor of MouseEventCallback.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220260

[wdzierzanowski, 2013-08-26 12:44:51]

Dear Reviewers,

Looking forward to your comments, if any.

Regards,
--Wojtek

[jam, 2013-08-26 14:43:01]

https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_...
File content/public/browser/mouse_listener.h (right):

https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_...
content/public/browser/mouse_listener.h:2: * Copyright (c) 2013, Opera Software
ASA. All rights reserved.
please use the standard chromium header on any new files (and specifically, the
copyright needs to be to the chromium authors).

https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_...
content/public/browser/mouse_listener.h:45: virtual bool HandleMouseEvent(const
WebKit::WebMouseEvent& event) = 0;
per http://www.chromium.org/developers/content-module/content-api, please use
callbacks instead of interfaces for single-method interfaces. i realize the
keyboard listener one was a bad example, i will fix that now.

[Ilya Sherman, 2013-08-26 20:58:23]

Not sure why I was listed as a reviewer... removing myself since John is already
reviewing.

[wdzierzanowski, 2013-08-27 09:26:06]

On 2013/08/26 14:43:01, jam wrote:
>
https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_...
> content/public/browser/mouse_listener.h:2: * Copyright (c) 2013, Opera
Software
> ASA. All rights reserved.
> please use the standard chromium header on any new files (and specifically,
the
> copyright needs to be to the chromium authors).

Right, will do in the future.  Not applicable here now that I've removed this
file.

>
https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_...
> content/public/browser/mouse_listener.h:45: virtual bool
HandleMouseEvent(const
> WebKit::WebMouseEvent& event) = 0;
> per http://www.chromium.org/developers/content-module/content-api, please use
> callbacks instead of interfaces for single-method interfaces. i realize the
> keyboard listener one was a bad example, i will fix that now.

Sure, OK.  Done.

[jam, 2013-08-27 16:17:53]

lgtm with nit

https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_impl.cc:1022: if
(MouseEventCallbacksHandleEvent(mouse_event.event))
nit: given the size of this function, why not just inline it here? also the
comment is describing pretty simple code, so remove per style guide

[wdzierzanowski, 2013-08-27 19:29:50]

https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_impl.cc:1022: if
(MouseEventCallbacksHandleEvent(mouse_event.event))
On 2013/08/27 16:17:53, jam wrote:
> nit: given the size of this function, why not just inline it here? also the
> comment is describing pretty simple code, so remove per style guide

In fact, I didn't care much for this being a separate function or the comment. I
was just trying to "fit in" with similar code for the keyboard events. Anyway,
the function is now inlined and the comment is gone.

[commit-bot: I haz the power, 2013-08-28 12:51:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/23416003/14001

[commit-bot: I haz the power, 2013-08-28 12:51:35]

Failed to apply patch for
content/browser/renderer_host/render_widget_host_impl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/renderer_host/render_widget_host_impl.h
  Hunk #1 FAILED at 175.
  Hunk #2 succeeded at 826 with fuzz 2 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
content/browser/renderer_host/render_widget_host_impl.h.rej

Patch:       content/browser/renderer_host/render_widget_host_impl.h
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h
b/content/browser/renderer_host/render_widget_host_impl.h
index
2004c0b663c8f5e332a90f44c9839242a230ffde..b05659814428f406616c7070b97f71001219eb96
100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -175,6 +175,10 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public
RenderWidgetHost,
   virtual void WasResized() OVERRIDE;
   virtual void AddKeyboardListener(KeyboardListener* listener) OVERRIDE;
   virtual void RemoveKeyboardListener(KeyboardListener* listener) OVERRIDE;
+  virtual void AddMouseEventCallback(
+      const MouseEventCallback& callback) OVERRIDE;
+  virtual void RemoveMouseEventCallback(
+      const MouseEventCallback& callback) OVERRIDE;
   virtual void GetWebScreenInfo(WebKit::WebScreenInfo* result) OVERRIDE;
   virtual void GetSnapshotFromRenderer(
       const gfx::Rect& src_subrect,
@@ -824,6 +828,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public
RenderWidgetHost,
   // Keyboard event listeners.
   ObserverList<KeyboardListener> keyboard_listeners_;
 
+  // Mouse event callbacks.
+  std::vector<MouseEventCallback> mouse_event_callbacks_;
+
   // If true, then we should repaint when restoring even if we have a
   // backingstore.  This flag is set to true if we receive a paint message
   // while is_hidden_ to true.  Even though we tell the render widget to hide

[commit-bot: I haz the power, 2013-08-29 08:30:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/23416003/18001

[commit-bot: I haz the power, 2013-08-29 11:20:56]

Change committed as 220260