Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 23416003: Add content::RenderWidgetHost::MouseEventCallback (Closed)

Created:
7 years, 3 months ago by wdzierzanowski
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add content::RenderWidgetHost::MouseEventCallback This adds the possibility to register mouse event callbacks with RenderWidgetHost and get notified about all kinds of mouse events. Any callback can "handle" the event, in which case it's not propagated to the renderer. Opera registers a mouse event callback to feed its mouse gesture recognizer with events. At this point, there is no other implementor of MouseEventCallback. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220260

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use a callback instead of a single-method interface #

Total comments: 2

Patch Set 3 : Get rid of the small helper function that was only called once #

Patch Set 4 : Rebased changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 3 chunks +27 lines, -2 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wdzierzanowski
Dear Reviewers, Looking forward to your comments, if any. Regards, --Wojtek
7 years, 3 months ago (2013-08-26 12:44:51 UTC) #1
jam
https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_listener.h File content/public/browser/mouse_listener.h (right): https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_listener.h#newcode2 content/public/browser/mouse_listener.h:2: * Copyright (c) 2013, Opera Software ASA. All rights ...
7 years, 3 months ago (2013-08-26 14:43:01 UTC) #2
Ilya Sherman
Not sure why I was listed as a reviewer... removing myself since John is already ...
7 years, 3 months ago (2013-08-26 20:58:23 UTC) #3
wdzierzanowski
On 2013/08/26 14:43:01, jam wrote: > https://codereview.chromium.org/23416003/diff/1/content/public/browser/mouse_listener.h#newcode2 > content/public/browser/mouse_listener.h:2: * Copyright (c) 2013, Opera Software ...
7 years, 3 months ago (2013-08-27 09:26:06 UTC) #4
jam
lgtm with nit https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_host/render_widget_host_impl.cc#newcode1022 content/browser/renderer_host/render_widget_host_impl.cc:1022: if (MouseEventCallbacksHandleEvent(mouse_event.event)) nit: given the size ...
7 years, 3 months ago (2013-08-27 16:17:53 UTC) #5
wdzierzanowski
https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/23416003/diff/9001/content/browser/renderer_host/render_widget_host_impl.cc#newcode1022 content/browser/renderer_host/render_widget_host_impl.cc:1022: if (MouseEventCallbacksHandleEvent(mouse_event.event)) On 2013/08/27 16:17:53, jam wrote: > nit: ...
7 years, 3 months ago (2013-08-27 19:29:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/23416003/14001
7 years, 3 months ago (2013-08-28 12:51:33 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_widget_host_impl.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-08-28 12:51:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wdzierzanowski@opera.com/23416003/18001
7 years, 3 months ago (2013-08-29 08:30:25 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 11:20:56 UTC) #10
Message was sent while issue was closed.
Change committed as 220260

Powered by Google App Engine
This is Rietveld 408576698