Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 23405002: This change modifies behavior of crash dialog in case of aura metro. (Closed)

Created:
7 years, 4 months ago by Shrikant Kelkar
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

This change modifies behavior of crash dialog in case of aura metro. If metro viewer instance was connected before crash then we won't show crash dialog. BUG=273185 R=cpu,ananta TBR=sky TESTS:Please see comment#2 in bug description and check if you see restart dialog when crashed from metro mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220460

Patch Set 1 #

Patch Set 2 : Modified comment #

Total comments: 2

Patch Set 3 : Changes according to code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/app/chrome_breakpad_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/common/env_vars.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/env_vars.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Shrikant Kelkar
7 years, 4 months ago (2013-08-23 19:54:12 UTC) #1
Shrikant Kelkar
7 years, 3 months ago (2013-08-27 01:01:35 UTC) #2
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/23405002/diff/3001/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc (right): https://codereview.chromium.org/23405002/diff/3001/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc#newcode77 chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc:77: scoped_ptr<base::Environment> env(base::Environment::Create()); don't use this method, just call the ...
7 years, 3 months ago (2013-08-27 17:40:37 UTC) #3
cpu_(ooo_6.6-7.5)
other than that. lgtm
7 years, 3 months ago (2013-08-27 17:41:15 UTC) #4
Shrikant Kelkar
https://codereview.chromium.org/23405002/diff/3001/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc (right): https://codereview.chromium.org/23405002/diff/3001/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc#newcode77 chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc:77: scoped_ptr<base::Environment> env(base::Environment::Create()); On 2013/08/27 17:40:37, cpu wrote: > don't ...
7 years, 3 months ago (2013-08-27 22:29:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/23405002/11001
7 years, 3 months ago (2013-08-27 23:42:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/23405002/11001
7 years, 3 months ago (2013-08-28 01:00:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=22690
7 years, 3 months ago (2013-08-28 03:29:21 UTC) #8
Shrikant Kelkar
+sky mainly for OWNERs chrome/common/env_vars.cc, chrome/common/env_vars.h
7 years, 3 months ago (2013-08-28 05:21:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/23405002/11001
7 years, 3 months ago (2013-08-29 21:34:02 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 00:53:38 UTC) #11
Message was sent while issue was closed.
Change committed as 220460

Powered by Google App Engine
This is Rietveld 408576698