Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 23383004: [Android Buildbot] Do not emit BUILD_STEP annotations for perf bisect. (Closed)

Created:
7 years, 4 months ago by Siva Chandra
Modified:
7 years, 4 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android Buildbot] Do not emit BUILD_STEP annotations for perf bisect. The perf bisect scripts emit their own annotations and we do not want to emit annotations outside of them and enter into an inconsistent state. BUG=266324 TBR=ilevy NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/android/buildbot/bb_host_steps.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Siva Chandra
7 years, 4 months ago (2013-08-21 18:26:37 UTC) #1
Mike Stip (use stip instead)
lgtm
7 years, 4 months ago (2013-08-21 21:13:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/23383004/1
7 years, 4 months ago (2013-08-21 21:28:54 UTC) #3
Isaac (away)
Why can we not emit a step here? Maybe I'm misreading the bug.
7 years, 4 months ago (2013-08-21 21:31:09 UTC) #4
Mike Stip (use stip instead)
the bisect scripts are annotated and create their own annotations. since the original step wasn't ...
7 years, 4 months ago (2013-08-21 21:35:47 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 21:36:29 UTC) #6
Message was sent while issue was closed.
Change committed as 218837

Powered by Google App Engine
This is Rietveld 408576698