Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc

Issue 2338283003: [Payments] Normalize addresses before passing them to merchants. (Closed)
Patch Set: Addressed vabr@'s comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "third_party/libaddressinput/chromium/chrome_address_validator.h" 5 #include "third_party/libaddressinput/chromium/chrome_address_validator.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 TEST_F(AddressValidatorTest, SuggestionsAreCleared) { 613 TEST_F(AddressValidatorTest, SuggestionsAreCleared) {
614 AddressData address; 614 AddressData address;
615 address.region_code = "US"; 615 address.region_code = "US";
616 616
617 std::vector<AddressData> suggestions(1, address); 617 std::vector<AddressData> suggestions(1, address);
618 EXPECT_EQ(AddressValidator::SUCCESS, 618 EXPECT_EQ(AddressValidator::SUCCESS,
619 validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions)); 619 validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
620 EXPECT_TRUE(suggestions.empty()); 620 EXPECT_TRUE(suggestions.empty());
621 } 621 }
622 622
623 TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaName) { 623 TEST_F(AddressValidatorTest, NormalizeUsAdminAreaName) {
624 AddressData address; 624 AddressData address;
625 address.region_code = "US"; 625 address.region_code = "US";
626 address.administrative_area = "cALIFORNIa"; 626 address.administrative_area = "cALIFORNIa";
627 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address)); 627 EXPECT_TRUE(validator_->NormalizeAddress(&address));
628 EXPECT_EQ("CA", address.administrative_area); 628 EXPECT_EQ("CA", address.administrative_area);
629 } 629 }
630 630
631 TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaKey) { 631 TEST_F(AddressValidatorTest, NormalizeUsAdminAreaKey) {
632 AddressData address; 632 AddressData address;
633 address.region_code = "US"; 633 address.region_code = "US";
634 address.administrative_area = "CA"; 634 address.administrative_area = "CA";
635 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address)); 635 EXPECT_TRUE(validator_->NormalizeAddress(&address));
636 EXPECT_EQ("CA", address.administrative_area); 636 EXPECT_EQ("CA", address.administrative_area);
637 } 637 }
638 638
639 TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaKey) { 639 TEST_F(AddressValidatorTest, NormalizeJpAdminAreaKey) {
640 validator_->LoadRules("JP"); 640 validator_->LoadRules("JP");
641 AddressData address; 641 AddressData address;
642 address.region_code = "JP"; 642 address.region_code = "JP";
643 address.administrative_area = "東京都"; 643 address.administrative_area = "東京都";
644 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address)); 644 EXPECT_TRUE(validator_->NormalizeAddress(&address));
645 EXPECT_EQ("東京都", address.administrative_area); 645 EXPECT_EQ("東京都", address.administrative_area);
646 } 646 }
647 647
648 TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaLatinName) { 648 TEST_F(AddressValidatorTest, NormalizeJpAdminAreaLatinName) {
649 validator_->LoadRules("JP"); 649 validator_->LoadRules("JP");
650 AddressData address; 650 AddressData address;
651 address.region_code = "JP"; 651 address.region_code = "JP";
652 address.administrative_area = "tOKYo"; 652 address.administrative_area = "tOKYo";
653 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address)); 653 EXPECT_TRUE(validator_->NormalizeAddress(&address));
654 EXPECT_EQ("TOKYO", address.administrative_area); 654 EXPECT_EQ("TOKYO", address.administrative_area);
655 } 655 }
656 656
657 TEST_F(AddressValidatorTest, AreRulesLoadedForRegion_NotLoaded) {
658 EXPECT_FALSE(validator_->AreRulesLoadedForRegion("JP"));
659 }
660
661 TEST_F(AddressValidatorTest, AreRulesLoadedForRegion_Loaded) {
662 validator_->LoadRules("JP");
663 EXPECT_TRUE(validator_->AreRulesLoadedForRegion("JP"));
664 }
665
657 TEST_F(AddressValidatorTest, TokushimaSuggestionIsValid) { 666 TEST_F(AddressValidatorTest, TokushimaSuggestionIsValid) {
658 validator_->LoadRules("JP"); 667 validator_->LoadRules("JP");
659 AddressData address; 668 AddressData address;
660 address.region_code = "JP"; 669 address.region_code = "JP";
661 address.administrative_area = "Toku"; 670 address.administrative_area = "Toku";
662 address.language_code = "ja-Latn"; 671 address.language_code = "ja-Latn";
663 672
664 std::vector<AddressData> suggestions; 673 std::vector<AddressData> suggestions;
665 EXPECT_EQ(AddressValidator::SUCCESS, 674 EXPECT_EQ(AddressValidator::SUCCESS,
666 validator_->GetSuggestions(address, ADMIN_AREA, 1, &suggestions)); 675 validator_->GetSuggestions(address, ADMIN_AREA, 1, &suggestions));
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 source_->set_failures_number(99); 891 source_->set_failures_number(99);
883 validator_->LoadRules("CH"); 892 validator_->LoadRules("CH");
884 validator_->LoadRules("GB"); 893 validator_->LoadRules("GB");
885 base::RunLoop().RunUntilIdle(); 894 base::RunLoop().RunUntilIdle();
886 895
887 EXPECT_FALSE(load_rules_success_); 896 EXPECT_FALSE(load_rules_success_);
888 EXPECT_EQ(16, source_->attempts_number()); 897 EXPECT_EQ(16, source_->attempts_number());
889 } 898 }
890 899
891 } // namespace autofill 900 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698