Add snapshotting for CIPD packages and dimensions to DM.

dm/api/distributor/swarming/v1/normalize.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarmingV1
 
 import (
         "errors"
         "fmt"
         "net/url"
@@ skipping 57 matching lines @@
         }
         for k := range j.Env {
                 if k == "" {
                         return errors.New("job.env: environment key is empty")
                 }
         }
         return
 }
 
 // Normalize normalizes and checks for input violations.
+func (p *CipdPackage) Normalize() error {
+        if p.Name == "" {
+                return errors.New("missing name")
+        }
+        if p.Version == "" {
+                return errors.New("missing version")
+        }
+        return nil
+}
+
+// Normalize normalizes and checks for input violations.
+func (c *CipdSpec) Normalize() error {
+        if err := schemaHostURLValidate(c.Server); err != nil {
+                return fmt.Errorf("job.inputs.cipd.server: %s", err)
+        }
+        if c.Client != nil {
+                if err := c.Client.Normalize(); err != nil {
+                        return fmt.Errorf("job.inputs.cipd.client: %s", err)
+                }
+        }
+        for path, pkgs := range c.ByPath {
+                for i, p := range pkgs.Pkg {
+                        if err := p.Normalize(); err != nil {
+                                return fmt.Errorf("job.inputs.cipd.by_path[%s].pkg[%d]: %s", path, i, err)
+                        }
+                }
+        }
+        return nil
+}
+
+// Normalize normalizes and checks for input violations.
 func (i *Parameters_Job_Inputs) Normalize() (err error) {
-        if len(i.Packages) == 0 && len(i.Isolated) == 0 {
+        if i.Cipd == nil && len(i.Isolated) == 0 {
                 return errors.New(
                         "job.inputs: at least one of packages and isolated must be specified")
         }
-        if len(i.Packages) > 0 {
-                if err = schemaHostURLValidate(i.CipdServer); err != nil {
-                        return fmt.Errorf("job.inputs.cipd_server: %s", err)
-                }
-                for i, p := range i.Packages {
-                        if p.Name == "" {
-                                return fmt.Errorf("job.inputs.packages[%d]: missing name", i)
-                        }
-                        if p.Version == "" {
-                                return fmt.Errorf("job.inputs.packages[%d]: missing version", i)
-                        }
+        if i.Cipd != nil {
+                if err = i.Cipd.Normalize(); err != nil {
+                        return
                 }
         }
         return
 }
 
 func schemaHostURLValidate(uStr string) error {
         if uStr == "" {
                 return errors.New("required")
         }
         if strings.IndexFunc(uStr, unicode.IsUpper) != -1 {
@@ skipping 31 matching lines @@
         return
 }
 
 // Normalize normalizes and checks for input violations.
 func (i *Config_Isolate) Normalize() (err error) {
         if err = schemaHostURLValidate(i.Url); err != nil {
                 return fmt.Errorf("config.isolate.host: %s", err)
         }
         return
 }