Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/renderer/media/midi_message_filter.h

Issue 23379002: Web MIDI: fix multi-threading problem around message buffer handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review #12 (for submmit) Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/media/midi_messages.h ('k') | content/renderer/media/midi_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/midi_message_filter.h
diff --git a/content/renderer/media/midi_message_filter.h b/content/renderer/media/midi_message_filter.h
index cf969e9d8078401a5de3b665b4a0ddfcae4a571f..4b8481fbc57690810adabe18ad8d5c5c9b1805b1 100644
--- a/content/renderer/media/midi_message_filter.h
+++ b/content/renderer/media/midi_message_filter.h
@@ -12,7 +12,6 @@
#include "content/common/content_export.h"
#include "ipc/ipc_channel_proxy.h"
#include "media/midi/midi_port_info.h"
-#include "third_party/WebKit/public/platform/WebMIDIAccessor.h"
#include "third_party/WebKit/public/platform/WebMIDIAccessorClient.h"
namespace base {
@@ -37,7 +36,7 @@ class CONTENT_EXPORT MIDIMessageFilter
// A client will only be able to call this method if it has a suitable
// output port (from addOutputPort()).
- void SendMIDIData(int port,
+ void SendMIDIData(uint32 port,
const uint8* data,
size_t length,
double timestamp);
@@ -69,7 +68,7 @@ class CONTENT_EXPORT MIDIMessageFilter
// Called when the browser process has sent MIDI data containing one or
// more messages.
- void OnDataReceived(int port,
+ void OnDataReceived(uint32 port,
const std::vector<uint8>& data,
double timestamp);
@@ -83,13 +82,13 @@ class CONTENT_EXPORT MIDIMessageFilter
media::MIDIPortInfoList inputs,
media::MIDIPortInfoList outputs);
- void HandleDataReceived(int port,
+ void HandleDataReceived(uint32 port,
const std::vector<uint8>& data,
double timestamp);
void StartSessionOnIOThread(int client_id);
- void SendMIDIDataOnIOThread(int port,
+ void SendMIDIDataOnIOThread(uint32 port,
const std::vector<uint8>& data,
double timestamp);
« no previous file with comments | « content/common/media/midi_messages.h ('k') | content/renderer/media/midi_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698