Record the reference time when Performance is constructed

Record the reference time when Performance is constructed.

BUG=264490
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156613

[James Simonsen, 2013-08-22 03:25:50]

PTAL

I tried following Nate's idea and checking for cases where the document is
detached. None of them triggered the crash either. It seems that we null out all
of the attributes when we detach.

He did point out that we shouldn't look at the current frame's document anyway,
because we may accidentally look at a different document. So, I've changed it to
cache the monotonic time value on construction.

[tonyg, 2013-08-23 00:01:06]

lgtm either way you decide to go

https://codereview.chromium.org/23367007/diff/4001/Source/core/page/Performan...
File Source/core/page/Performance.cpp (right):

https://codereview.chromium.org/23367007/diff/4001/Source/core/page/Performan...
Source/core/page/Performance.cpp:62: m_referenceTime =
m_frame->document()->loader()->timing()->referenceMonotonicTime();
I don't think the asserts are going to teach you anything here and I suspect the
move will fix the crasher.

What do you think about moving this to the initializer list and removing the
asserts?

[James Simonsen, 2013-08-23 02:04:31]

On 2013/08/23 00:01:06, tonyg wrote:
> lgtm either way you decide to go
> 
>
https://codereview.chromium.org/23367007/diff/4001/Source/core/page/Performan...
> File Source/core/page/Performance.cpp (right):
> 
>
https://codereview.chromium.org/23367007/diff/4001/Source/core/page/Performan...
> Source/core/page/Performance.cpp:62: m_referenceTime =
> m_frame->document()->loader()->timing()->referenceMonotonicTime();
> I don't think the asserts are going to teach you anything here and I suspect
the
> move will fix the crasher.
> 
> What do you think about moving this to the initializer list and removing the
> asserts?

Done. It was mostly that way to see all the layout tests pass (in debug).

[commit-bot: I haz the power, 2013-08-23 02:04:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonjam@chromium.org/23367007/10001

[commit-bot: I haz the power, 2013-08-23 03:40:10]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-08-23 04:02:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonjam@chromium.org/23367007/10001

[commit-bot: I haz the power, 2013-08-23 04:03:33]

Change committed as 156613