cc/layers/texture_layer.cc - Issue 23364002: asan use after free in Aura cc:TextureLayer::Update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/texture_layer.cc

Issue 23364002: asan use after free in Aura cc:TextureLayer::Update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/texture_layer.cc

diff --git a/cc/layers/texture_layer.cc b/cc/layers/texture_layer.cc

index 316042b861a969dabd71a3bda0bc3b926c3aac3a..be56444ca4a7afb230759b81ce822a9a95391477 100644

--- a/cc/layers/texture_layer.cc

+++ b/cc/layers/texture_layer.cc

@@ -189,8 +189,8 @@ bool TextureLayer::Update(ResourceUpdateQueue* queue,

updated = true;

}

} else {

- DCHECK(client_->Context3d());

texture_id_ = client_->PrepareTexture();

+ DCHECK(!texture_id_ || client_->Context3d());

if (client_->Context3d() &&

client_->Context3d()->getGraphicsResetStatusARB() != GL_NO_ERROR)

texture_id_ = 0;