Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 23346011: Fixes TestContentProvider issues in AndroidWebView (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes TestContentProvider issues in AndroidWebView NOTRY=True BUG=278326 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219347

Patch Set 1 #

Patch Set 2 : Adds a hack for test apk cycling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M android_webview/javatests/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/test/shell/AndroidManifest.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gkanwar1
Fix tested locally and it appears to work, ptal. joth -- you were on OWNERs, ...
7 years, 4 months ago (2013-08-23 16:22:19 UTC) #1
mkosiba (inactive)
LGTM if it fixes the test :)
7 years, 4 months ago (2013-08-23 16:29:28 UTC) #2
gkanwar1
Great, thanks. Let's hope the trybots pass then...
7 years, 4 months ago (2013-08-23 16:40:55 UTC) #3
gkanwar1
> build/android/adb_install_apk.py --apk AndroidWebView.apk --apk_package org.chromium.android_webview.shell Traceback (most recent call last): File "build/android/adb_install_apk.py", line 77, ...
7 years, 4 months ago (2013-08-23 18:07:48 UTC) #4
gkanwar1
Looks like the issue was the the old test apk had the content provider that ...
7 years, 4 months ago (2013-08-23 18:51:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23346011/11001
7 years, 4 months ago (2013-08-23 21:39:39 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 21:42:07 UTC) #7
Message was sent while issue was closed.
Change committed as 219347

Powered by Google App Engine
This is Rietveld 408576698