Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2324)

Unified Diff: build/android/gyp/emma_instr.py

Issue 23345003: [Android] Buildbot changes for EMMA code coverage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds TODO to remove *_sources.txt try/except Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/generate_emma_html.py ('k') | build/android/instr_action.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/emma_instr.py
diff --git a/build/android/gyp/emma_instr.py b/build/android/gyp/emma_instr.py
index c682163b277a9864f79d22ca252230f07cca8cb6..8e69f395bc15492bb9c4e3c93789f3614b67a46a 100755
--- a/build/android/gyp/emma_instr.py
+++ b/build/android/gyp/emma_instr.py
@@ -48,7 +48,7 @@ def _AddInstrumentOptions(option_parser):
"""Adds options related to instrumentation to |option_parser|."""
_AddCommonOptions(option_parser)
option_parser.add_option('--coverage-file',
- help='File to create with coverage metadata')
+ help='File to create with coverage metadata.')
option_parser.add_option('--sources-file',
help='File to create with the list of sources.')
option_parser.add_option('--sources',
@@ -132,6 +132,10 @@ def _RunInstrumentCommand(command, options, args, option_parser):
options.src_root and options.emma_jar):
option_parser.error('All arguments are required.')
+ coverage_file = os.path.join(os.path.dirname(options.output_path),
+ options.coverage_file)
+ sources_file = os.path.join(os.path.dirname(options.output_path),
+ options.sources_file)
temp_dir = tempfile.mkdtemp()
try:
# TODO(gkanwar): Add '-ix' option to filter out useless classes.
@@ -139,7 +143,7 @@ def _RunInstrumentCommand(command, options, args, option_parser):
'emma', 'instr',
'-ip', options.input_path,
'-d', temp_dir,
- '-out', options.coverage_file,
+ '-out', coverage_file,
'-m', 'fullcopy'], suppress_output=True)
if command == 'instrument_jar':
@@ -154,7 +158,7 @@ def _RunInstrumentCommand(command, options, args, option_parser):
finally:
shutil.rmtree(temp_dir)
- _CreateSourcesFile(options.sources, options.sources_file, options.src_root)
+ _CreateSourcesFile(options.sources, sources_file, options.src_root)
if options.stamp:
build_utils.Touch(options.stamp)
« no previous file with comments | « build/android/generate_emma_html.py ('k') | build/android/instr_action.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698