Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 23344004: Use CopyResourceOnServer to upload JSON GDoc file on Drive API v2. (Closed)

Created:
7 years, 4 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use CopyResourceOnServer to upload JSON GDoc file on Drive API v2. Drive API v2 can copy a file not only into root directory but also other directory directly, and it should more efficient and simpler. This CL uses it to upload JSON GDoc file. BUG=277353 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221697

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 5 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 1 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance. Note that I'm thinking we probably should wait ...
7 years, 4 months ago (2013-08-26 07:18:21 UTC) #1
kinaba
On 2013/08/26 07:18:21, hidehiko wrote: > Thank you for your review in advance. > Note ...
7 years, 4 months ago (2013-08-26 08:25:04 UTC) #2
hidehiko
On 2013/08/26 08:25:04, kinaba wrote: > On 2013/08/26 07:18:21, hidehiko wrote: > > Thank you ...
7 years, 3 months ago (2013-09-06 10:17:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23344004/5001
7 years, 3 months ago (2013-09-06 10:17:23 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 13:13:56 UTC) #5
Message was sent while issue was closed.
Change committed as 221697

Powered by Google App Engine
This is Rietveld 408576698