Virtual Keyboard Shift Highlight fixed.

Virtual Keyboard Shift Highlight fixed.
BUG=261415
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220089

[rsadam, 2013-08-26 18:09:03]

Removed dependency on "upper" hardcoded string.

[bshe, 2013-08-28 16:35:03]

Sorry for the delay. I totally missed this review yesterday.

lgtm with one small nit.

This becomes more and more complicated. We should probably continue to do some
refactor like we discussed offline.

https://codereview.chromium.org/23332022/diff/1/ui/keyboard/resources/layouts...
File ui/keyboard/resources/layouts/qwerty.html (right):

https://codereview.chromium.org/23332022/diff/1/ui/keyboard/resources/layouts...
ui/keyboard/resources/layouts/qwerty.html:12: <kb-keyset id="qwerty-upper"
lockable='true'>
Could you use double quote instead of single quote?

[bshe, 2013-08-28 16:36:04]

On 2013/08/28 16:35:03, bshe wrote:
> Sorry for the delay. I totally missed this review yesterday.
> 
> lgtm with one small nit.
> 
> This becomes more and more complicated. We should probably continue to do some
> refactor like we discussed offline.
> 
>
https://codereview.chromium.org/23332022/diff/1/ui/keyboard/resources/layouts...
> File ui/keyboard/resources/layouts/qwerty.html (right):
> 
>
https://codereview.chromium.org/23332022/diff/1/ui/keyboard/resources/layouts...
> ui/keyboard/resources/layouts/qwerty.html:12: <kb-keyset id="qwerty-upper"
> lockable='true'>
> Could you use double quote instead of single quote?

forgot to mention another thing. you need to add the lockable attribute to
webui_qwerty.html and other html files
in the layout directory.

[commit-bot: I haz the power, 2013-08-28 17:02:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/23332022/7001

[commit-bot: I haz the power, 2013-08-28 21:00:38]

Change committed as 220089