Issue 23320004: reland 'Set chrome_multiple_dll=1 by default on Windows in static_library'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23320004: reland 'Set chrome_multiple_dll=1 by default on Windows in static_library' (Closed)

Created:
7 years, 4 months ago by scottmg

Modified:
7 years, 4 months ago

Reviewers:
jamesr, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/chrome_main_delegate.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_android.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

scottmg

i couldn't get the naclmore bot to complete, nor repro locally, but i think it ...

7 years, 4 months ago (2013-08-20 21:42:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23320004/10001

7 years, 4 months ago (2013-08-21 01:32:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23320004/10001

7 years, 4 months ago (2013-08-21 04:57:49 UTC) #4

Message was sent while issue was closed.

Change committed as 218663