Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 23320003: Add toSVGCircleElement(), and use it (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toSVGCircleElement(), and use it As a step to clean-up static_cast<SVGXXX>, static_cast<SVGCircleElement*> also can be changed with toSVGCircleElement(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 4 months ago (2013-08-19 16:40:18 UTC) #1
tkent
lgtm
7 years, 4 months ago (2013-08-19 22:40:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23320003/1
7 years, 4 months ago (2013-08-19 22:40:53 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 00:36:56 UTC) #4
Message was sent while issue was closed.
Change committed as 156348

Powered by Google App Engine
This is Rietveld 408576698