Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 23314002: drawSystemFocusRing should take canvas transformations into account. (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, Rik, aboxhall, eae+blinkwatch, dglazkov+blink, dmazzoni, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

drawSystemFocusRing should take canvas transformations into account. In addition, the accessible rect needs to be applied to ancesetor elements within the canvas, otherwise their bounding boxes may be clipped. BUG=261998 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156371

Patch Set 1 #

Total comments: 4

Patch Set 2 : Test canvas element instead of role when walking up parents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M LayoutTests/accessibility/draw-custom-focus-ring.html View 2 chunks +16 lines, -3 lines 0 comments Download
M LayoutTests/accessibility/draw-custom-focus-ring-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
7 years, 4 months ago (2013-08-19 06:24:42 UTC) #1
Stephen White
LGTM; my questions may be dumb https://codereview.chromium.org/23314002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/23314002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2396 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2396: elementRect.moveBy(canvasRect.location()); Not new ...
7 years, 4 months ago (2013-08-19 18:08:04 UTC) #2
dmazzoni
https://codereview.chromium.org/23314002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/23314002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2396 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2396: elementRect.moveBy(canvasRect.location()); On 2013/08/19 18:08:04, Stephen White wrote: > Not ...
7 years, 4 months ago (2013-08-20 06:01:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23314002/6001
7 years, 4 months ago (2013-08-20 06:01:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 4 months ago (2013-08-20 06:16:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23314002/6001
7 years, 4 months ago (2013-08-20 06:36:56 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 07:34:55 UTC) #7
Message was sent while issue was closed.
Change committed as 156371

Powered by Google App Engine
This is Rietveld 408576698