Issue 23311008: Tab Strip: Initialize the blocked state for a tab.

Issue 23311008: Tab Strip: Initialize the blocked state for a tab. (Closed)

Created:
7 years, 4 months ago by Lei Zhang

Modified:
7 years, 3 months ago

Reviewers:
Mike Wittman, sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Tab Strip: Initialize the blocked state for a tab. BUG=276334 TEST=Manual, see bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220435

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix test for win aura #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -0 lines)			Patch
	M	chrome/browser/ui/tabs/tab_strip_model.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/tabs/tab_strip_model_unittest.cc	View	1 2	4 chunks	+114 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/23311008/8001

7 years, 4 months ago (2013-08-22 21:24:45 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=72154

7 years, 4 months ago (2013-08-22 23:53:40 UTC) #6

Lei Zhang

For whatever reason, win7_aura did not like patch set 1 because of the TabStripModel destruction ...

7 years, 3 months ago (2013-08-29 21:42:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/23311008/57001

7 years, 3 months ago (2013-08-29 21:43:08 UTC) #8

Message was sent while issue was closed.

Change committed as 220435

Expand Messages | Collapse Messages