Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 23297004: Remove ExtraLanguage entries from InputMethodUtil. (Closed)

Created:
7 years, 4 months ago by Seigo Nonaka
Modified:
7 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove ExtraLanguage entries from InputMethodUtil. Now InputMethod can be associated with multiple languages, so ExtraLanguage struct in InputMethodUtil is no longer necessary and update input_methods.txt to be able to specify multiple languages. BUG=None TEST=US-international keyboard layout is still available on Portuguese entry. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219131

Patch Set 1 #

Patch Set 2 : Remove obsolete tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -122 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 3 chunks +0 lines, -58 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc View 1 4 chunks +1 line, -13 lines 0 comments Download
M chromeos/ime/input_method_whitelist.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/ime/input_methods.txt View 4 chunks +6 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
Hi Zach, could you take a look?
7 years, 4 months ago (2013-08-20 10:27:56 UTC) #1
Seigo Nonaka
friendly ping
7 years, 4 months ago (2013-08-21 22:56:09 UTC) #2
Zachary Kuznia
lgtm
7 years, 4 months ago (2013-08-21 23:10:24 UTC) #3
Seigo Nonaka
Zach, Thank you for your review! Adding nkostylev@ as the owner of chrome/browser/ui/webui/options/chromeos/*. Hi Nikita, ...
7 years, 4 months ago (2013-08-21 23:49:33 UTC) #4
Nikita (slow)
lgtm
7 years, 4 months ago (2013-08-22 14:36:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/23297004/5001
7 years, 4 months ago (2013-08-22 16:09:44 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 22:24:43 UTC) #7
Message was sent while issue was closed.
Change committed as 219131

Powered by Google App Engine
This is Rietveld 408576698