Issue 23295007: [Android] Fixes host-driven Feature annotation

Issue 23295007: [Android] Fixes host-driven Feature annotation (Closed)

Created:
7 years, 4 months ago by gkanwar1

Modified:
7 years, 4 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixes host-driven Feature annotation NOTRY=True BUG=176323 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218453

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/android/pylib/host_driven/tests_annotations.py	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/23295007/diff/1/build/android/pylib/host_driven/tests_annotations.py File build/android/pylib/host_driven/tests_annotations.py (right): https://codereview.chromium.org/23295007/diff/1/build/android/pylib/host_driven/tests_annotations.py#newcode91 build/android/pylib/host_driven/tests_annotations.py:91: AnnotatedFunctions._AddFunction('Feature:%s' % feature, function) Assuming this is used ...

7 years, 4 months ago (2013-08-19 18:08:36 UTC) #2

gkanwar1

Thanks, submitting. https://codereview.chromium.org/23295007/diff/1/build/android/pylib/host_driven/tests_annotations.py File build/android/pylib/host_driven/tests_annotations.py (right): https://codereview.chromium.org/23295007/diff/1/build/android/pylib/host_driven/tests_annotations.py#newcode91 build/android/pylib/host_driven/tests_annotations.py:91: AnnotatedFunctions._AddFunction('Feature:%s' % feature, function) On 2013/08/19 18:08:36, ...

7 years, 4 months ago (2013-08-19 18:10:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23295007/1

7 years, 4 months ago (2013-08-19 18:11:09 UTC) #4

Message was sent while issue was closed.

Change committed as 218453

Expand Messages | Collapse Messages