Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: Source/web/InspectorFrontendClientImpl.cpp

Issue 23290002: Complete migration to InspectorFrontendHost.sendMessageToFrontendHost. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/InspectorFrontendClientImpl.cpp
diff --git a/Source/web/InspectorFrontendClientImpl.cpp b/Source/web/InspectorFrontendClientImpl.cpp
index 21076b4e13587d8e7598e6a9e7a1a25c15eeeb72..062a9ae68c3cc647606eb22d8ab2fc023d3bdf82 100644
--- a/Source/web/InspectorFrontendClientImpl.cpp
+++ b/Source/web/InspectorFrontendClientImpl.cpp
@@ -79,70 +79,23 @@ void InspectorFrontendClientImpl::windowObjectCleared()
if (scriptController) {
String installLegacyOverrides =
"(function(host) {"
- " function dispatch(oldImpl, methodName) {"
- " var argsArray = Array.prototype.slice.call(arguments, 2);"
+ " function dispatch(methodName) {"
+ " var argsArray = Array.prototype.slice.call(arguments, 1);"
" var message = {'method': methodName};"
" if (argsArray.length)"
" message.params = argsArray;"
" this.sendMessageToFrontendHost(JSON.stringify(message));"
- " oldImpl.apply(this, argsArray);"
" };"
" var legacyMethods = ['requestSetDockSide', 'closeWindow', 'bringToFront', 'setAttachedWindowHeight', 'moveWindowBy', 'openInNewTab',"
" 'save', 'append', 'requestFileSystems', 'addFileSystem', 'removeFileSystem', 'indexPath', 'stopIndexing', 'searchInPath' ];"
" legacyMethods.forEach(function(methodName) {"
- " host[methodName] = dispatch.bind(host, host[method], methodName);"
+ " host[methodName] = dispatch.bind(host, methodName);"
" });"
"})(InspectorFrontendHost);";
scriptController->executeScriptInMainWorld(ScriptSourceCode(installLegacyOverrides));
}
}
-void InspectorFrontendClientImpl::moveWindowBy(float x, float y)
-{
- m_client->moveWindowBy(WebFloatPoint(x, y));
-}
-
-void InspectorFrontendClientImpl::bringToFront()
-{
- m_client->activateWindow();
-}
-
-void InspectorFrontendClientImpl::closeWindow()
-{
- m_client->closeWindow();
-}
-
-void InspectorFrontendClientImpl::requestSetDockSide(DockSide side)
-{
- String sideString = "undocked";
- switch (side) {
- case DockedToRight: sideString = "right"; break;
- case DockedToBottom: sideString = "bottom"; break;
- case Undocked: sideString = "undocked"; break;
- }
- m_client->requestSetDockSide(sideString);
-}
-
-void InspectorFrontendClientImpl::changeAttachedWindowHeight(unsigned height)
-{
- m_client->changeAttachedWindowHeight(height);
-}
-
-void InspectorFrontendClientImpl::openInNewTab(const String& url)
-{
- m_client->openInNewTab(url);
-}
-
-void InspectorFrontendClientImpl::save(const String& url, const String& content, bool forceSaveAs)
-{
- m_client->save(url, content, forceSaveAs);
-}
-
-void InspectorFrontendClientImpl::append(const String& url, const String& content)
-{
- m_client->append(url, content);
-}
-
void InspectorFrontendClientImpl::inspectedURLChanged(const String& url)
{
m_frontendPage->mainFrame()->document()->setTitle("Developer Tools - " + url);
@@ -158,36 +111,6 @@ void InspectorFrontendClientImpl::sendMessageToFrontendHost(const String& messag
m_client->sendMessageToFrontendHost(message);
}
-void InspectorFrontendClientImpl::requestFileSystems()
-{
- m_client->requestFileSystems();
-}
-
-void InspectorFrontendClientImpl::indexPath(int requestId, const String& fileSystemPath)
-{
- m_client->indexPath(requestId, fileSystemPath);
-}
-
-void InspectorFrontendClientImpl::stopIndexing(int requestId)
-{
- m_client->stopIndexing(requestId);
-}
-
-void InspectorFrontendClientImpl::searchInPath(int requestId, const String& fileSystemPath, const String& query)
-{
- m_client->searchInPath(requestId, fileSystemPath, query);
-}
-
-void InspectorFrontendClientImpl::addFileSystem()
-{
- m_client->addFileSystem();
-}
-
-void InspectorFrontendClientImpl::removeFileSystem(const String& fileSystemPath)
-{
- m_client->removeFileSystem(fileSystemPath);
-}
-
bool InspectorFrontendClientImpl::isUnderTest()
{
return m_client->isUnderTest();

Powered by Google App Engine
This is Rietveld 408576698