Issue 23290002: Complete migration to InspectorFrontendHost.sendMessageToFrontendHost.

Issue 23290002: Complete migration to InspectorFrontendHost.sendMessageToFrontendHost. (Closed)

Created:
7 years, 4 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Complete migration to InspectorFrontendHost.sendMessageToFrontendHost. BUG=278002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157361

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Addressed comment #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Do not send setAttachedWindowHeight to the embedder as it is obsolete #

Patch Set 8 : Rebase #

Patch Set 9 : Addressed comments #

Patch Set 10 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -271 lines)			Patch
M	Source/core/inspector/InspectorFrontendClient.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -25 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.h	View	1 2 3 4 5 6	2 chunks	+0 lines, -12 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.cpp	View	1 2 3 4 5 6 7 8 9	4 chunks	+0 lines, -81 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.idl	View	1 2 3 4 5 6	2 chunks	+0 lines, -12 lines	0 comments	Download
M	Source/core/testing/InspectorFrontendClientLocal.h	View	1 2 3	1 chunk	+1 line, -21 lines	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.h	View	1 2 3	1 chunk	+1 line, -20 lines	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.cpp	View	1 2 3 4 5 6 7 8 9	3 chunks	+3 lines, -81 lines	0 comments	Download
M	public/web/WebDevToolsFrontendClient.h	View	1 2 3	1 chunk	+1 line, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/23290002/diff/7001/Source/core/inspector/InspectorFrontendHost.cpp File Source/core/inspector/InspectorFrontendHost.cpp (left): https://codereview.chromium.org/23290002/diff/7001/Source/core/inspector/InspectorFrontendHost.cpp#oldcode144 Source/core/inspector/InspectorFrontendHost.cpp:144: m_client->requestSetDockSide(InspectorFrontendClient::Undocked); Remove these constants as well. https://codereview.chromium.org/23290002/diff/7001/Source/core/inspector/InspectorFrontendHost.cpp#oldcode155 Source/core/inspector/InspectorFrontendHost.cpp:155: disconnectClient(); ...

7 years, 4 months ago (2013-08-23 11:34:15 UTC) #2

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/23290002/diff/7001/Source/core/inspector/InspectorFrontendHost.cpp File Source/core/inspector/InspectorFrontendHost.cpp (left): https://chromiumcodereview.appspot.com/23290002/diff/7001/Source/core/inspector/InspectorFrontendHost.cpp#oldcode144 Source/core/inspector/InspectorFrontendHost.cpp:144: m_client->requestSetDockSide(InspectorFrontendClient::Undocked); On 2013/08/23 11:34:15, pfeldman wrote: > Remove these ...

7 years, 3 months ago (2013-08-30 14:37:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23290002/29001

7 years, 3 months ago (2013-09-06 08:00:49 UTC) #5

Message was sent while issue was closed.

Change committed as 157361

Expand Messages | Collapse Messages