Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23289002: Introduce InspectorFrontendHost.sendMessageToFrontendHost. (Closed)

Created:
7 years, 4 months ago by Vladislav Kaznacheev
Modified:
7 years, 3 months ago
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Introduce InspectorFrontendHost.sendMessageToFrontendHost. BUG=278002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156990

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 9

Patch Set 3 : Addressed comments #

Patch Set 4 : Fixed 'closeWindow' #

Patch Set 5 : Used JSONObject #

Patch Set 6 : Rebase #

Patch Set 7 : Do not send setAttachedWindowHeight to the embedder as it is obsolete #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M Source/core/inspector/InspectorFrontendClient.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 2 3 4 5 6 7 3 chunks +10 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/InspectorFrontendClientLocal.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/InspectorFrontendHostStub.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/InspectorFrontendClientImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/InspectorFrontendClientImpl.cpp View 1 2 3 4 5 6 2 chunks +38 lines, -0 lines 0 comments Download
M public/web/WebDevToolsFrontendClient.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vladislav Kaznacheev
7 years, 4 months ago (2013-08-23 07:13:17 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/23289002/diff/3001/Source/core/inspector/InspectorFrontendClient.h File Source/core/inspector/InspectorFrontendClient.h (right): https://codereview.chromium.org/23289002/diff/3001/Source/core/inspector/InspectorFrontendClient.h#newcode66 Source/core/inspector/InspectorFrontendClient.h:66: virtual void sendMessageToFrontendHost(const String&) = 0; sendMessageToEmbedder https://codereview.chromium.org/23289002/diff/3001/Source/core/inspector/InspectorFrontendHost.idl ...
7 years, 4 months ago (2013-08-23 11:20:27 UTC) #2
Vladislav Kaznacheev
https://codereview.chromium.org/23289002/diff/3001/Source/core/inspector/InspectorFrontendClient.h File Source/core/inspector/InspectorFrontendClient.h (right): https://codereview.chromium.org/23289002/diff/3001/Source/core/inspector/InspectorFrontendClient.h#newcode66 Source/core/inspector/InspectorFrontendClient.h:66: virtual void sendMessageToFrontendHost(const String&) = 0; On 2013/08/23 11:20:27, ...
7 years, 4 months ago (2013-08-23 13:05:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23289002/22001
7 years, 4 months ago (2013-08-23 13:23:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=5889
7 years, 4 months ago (2013-08-23 13:35:44 UTC) #5
Vladislav Kaznacheev
Hi Dimitri, Please review the change to public/web/WebDevToolsFrontendClient.h Thanks, Vlad
7 years, 4 months ago (2013-08-23 13:43:49 UTC) #6
Vladislav Kaznacheev
Gentle ping. On 2013/08/23 13:43:49, Vladislav Kaznacheev wrote: > Hi Dimitri, > > Please review ...
7 years, 3 months ago (2013-08-28 15:09:33 UTC) #7
Vladislav Kaznacheev
Hi Darin, Please review the change to public/web/WebDevToolsFrontendClient.h Thanks, Vlad
7 years, 3 months ago (2013-08-29 11:08:02 UTC) #8
tkent
public/web lgtm.
7 years, 3 months ago (2013-08-30 09:56:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23289002/40001
7 years, 3 months ago (2013-08-30 12:05:28 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 14:06:00 UTC) #11
Message was sent while issue was closed. 
Change committed as 156990

Powered by Google App Engine
This is Rietveld 408576698