Issue 23287005: CSS Animations: Clamp to avoid underflow when blending unsigned values

Issue 23287005: CSS Animations: Clamp to avoid underflow when blending unsigned values (Closed)

Created:
7 years, 4 months ago by dstockwell

Modified:
7 years, 4 months ago

Reviewers:
Steve Block

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), jeez, eae+blinkwatch, Timothy Loh, dglazkov+blink, darktears, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

CSS Animations: Clamp to avoid underflow when blending unsigned values Previously our implementation could underflow when given a timing function that produced values outside 0-1. This change clamps any possible underflow of unsigned interpolation to produce 0. This affects interpolation of the following properties: border-*-width (specified to be interpolated as length) -webkit-column-rule-width (specified to be interpolated as length) -webkit-column-count (specified to be interpolated as integer) outline-width (specified to be interpolated as length) Interpolation of these types is defined here: http://dev.w3.org/csswg/css-transitions/#animtype-length http://dev.w3.org/csswg/css-transitions/#animtype-integer Both are "interpolated as real numbers" and integer is then "converted to an integer by rounding to the nearest integer" Clamping to 0 matches the behavior of Firefox for the test added here. BUG=276109 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156453

Patch Set 1 #

Total comments: 1

Patch Set 2 : Describe test #

Patch Set 3 : Update TestExpectations #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -1 line)			Patch
A	LayoutTests/animations/unsigned-underflow.html	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/unsigned-underflow-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/platform/animation/AnimationUtilities.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Steve Block

I assume this is the correct behaviour, but do you have a link to a ...

7 years, 4 months ago (2013-08-20 06:56:08 UTC) #2

dstockwell

On 2013/08/20 06:56:08, Steve Block wrote: > I assume this is the correct behaviour, but ...

7 years, 4 months ago (2013-08-20 07:55:45 UTC) #3

Steve Block

lgtm > Previously we underflowed, the test added here produced: > FAIL - "border-top-width" property ...

7 years, 4 months ago (2013-08-21 00:32:53 UTC) #4