Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 23283009: Convert SecurityError exceptions to 'es.throwSecurityError()'. (Closed)

Created:
7 years, 4 months ago by Mike West
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Convert SecurityError exceptions to 'es.throwSecurityError()'. This patch moves several SecurityError exceptions over to the new API, and adds comments to the code to make it clear why URLs are exposed to JavaScript in the cases where a URL is exposed. BUG=275282 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156298

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M LayoutTests/http/tests/workers/resources/worker-redirect.js View 1 chunk +1 line, -1 line 1 comment Download
A + LayoutTests/http/tests/workers/resources/worker-target.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/http/tests/workers/shared-worker-redirect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/workers/worker-redirect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/History.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Excitement abounds! EXCEPTIONAL excitement! -mike https://codereview.chromium.org/23283009/diff/1/LayoutTests/http/tests/workers/resources/worker-redirect.js File LayoutTests/http/tests/workers/resources/worker-redirect.js (left): https://codereview.chromium.org/23283009/diff/1/LayoutTests/http/tests/workers/resources/worker-redirect.js#oldcode28 LayoutTests/http/tests/workers/resources/worker-redirect.js:28: var worker = createWorker('http://localhost:8000/workers/resources/worker-redirect-target.js'); ...
7 years, 4 months ago (2013-08-19 08:15:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-19 08:49:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23283009/1
7 years, 4 months ago (2013-08-19 08:59:11 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 09:48:56 UTC) #4
Message was sent while issue was closed.
Change committed as 156298

Powered by Google App Engine
This is Rietveld 408576698