Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 23283007: Move kJavaScriptScheme into content namespace. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, tfarina, browser-components-watch_chromium.org, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, James Su, android-webview-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : content:: is necessary in web_drag_source_mac.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M android_webview/renderer/aw_render_view_ext.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/web_drag_bookmark_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_controller_factory_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
7 years, 4 months ago (2013-08-19 03:18:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23283007/1
7 years, 4 months ago (2013-08-19 03:18:52 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-19 04:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23283007/14002
7 years, 4 months ago (2013-08-19 04:06:29 UTC) #4
commit-bot: I haz the power
Change committed as 218244
7 years, 4 months ago (2013-08-19 07:59:39 UTC) #5
jam
7 years, 4 months ago (2013-08-25 07:25:22 UTC) #6
Message was sent while issue was closed.
On 2013/08/19 07:59:39, I haz the power (commit-bot) wrote:
> Change committed as 218244

lgtm

Powered by Google App Engine
This is Rietveld 408576698