Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: net/quic/quic_client_session.h

Issue 23279011: Require handshake confirmation until a QUIC connection is created succesfully when using a new netw… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | net/quic/quic_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.h
diff --git a/net/quic/quic_client_session.h b/net/quic/quic_client_session.h
index 339c40b2ba1c098adc9b63d26eb7be742b149eab..ac5c343d05666dca1b7b56f3b93059f4e3025f1b 100644
--- a/net/quic/quic_client_session.h
+++ b/net/quic/quic_client_session.h
@@ -108,7 +108,8 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicSession {
virtual void ConnectionClose(QuicErrorCode error, bool from_peer) OVERRIDE;
// Performs a crypto handshake with the server.
- int CryptoConnect(const CompletionCallback& callback);
+ int CryptoConnect(bool require_confirmation,
+ const CompletionCallback& callback);
// Causes the QuicConnectionHelper to start reading from the socket
// and passing the data along to the QuicConnection.
@@ -147,7 +148,7 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicSession {
// delete |this|.
void NotifyFactoryOfSessionClose();
- base::WeakPtrFactory<QuicClientSession> weak_factory_;
+ bool require_confirmation_;
scoped_ptr<QuicCryptoClientStream> crypto_stream_;
QuicStreamFactory* stream_factory_;
scoped_ptr<DatagramClientSocket> socket_;
@@ -158,6 +159,7 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicSession {
size_t num_total_streams_;
BoundNetLog net_log_;
QuicConnectionLogger logger_;
+ base::WeakPtrFactory<QuicClientSession> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(QuicClientSession);
};
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | net/quic/quic_network_transaction_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698