Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23271006: libpng 1.6.3 (Closed)

Created:
7 years, 4 months ago by Dominik Grewe
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

libpng 1.6.3 Update libpng from version 1.2.45 to 1.6.3. Enable NEON implementation of libpng for ARM devices running Android. libpng performs a check a runtime to see if the device actually supports NEON. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224858

Patch Set 1 #

Patch Set 2 : Fix macros & gyp file. #

Patch Set 3 : Fix gyp file. #

Patch Set 4 : Fix macros & enable NEON for all ARM devices. #

Patch Set 5 : Fix macros & gyp file. #

Total comments: 4

Patch Set 6 : Add PNG_SAFE_LIMITS_SUPPORTED & remove PNG_SEQUENTIAL_READ_SUPPORTED. #

Patch Set 7 : Fix gyp files# #

Patch Set 8 : Fix macros (accidentally changed in previous patch set). #

Patch Set 9 : Remove trailing whitespaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24362 lines, -14402 lines) Patch
M third_party/libpng/LICENSE View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libpng/README View 1 2 3 4 5 6 7 8 7 chunks +38 lines, -111 lines 0 comments Download
M third_party/libpng/README.chromium View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -1 line 0 comments Download
A third_party/libpng/arm/arm_init.c View 1 2 3 4 5 6 7 8 1 chunk +221 lines, -0 lines 0 comments Download
A third_party/libpng/arm/filter_neon.S View 1 2 3 4 5 6 7 8 1 chunk +237 lines, -0 lines 0 comments Download
M third_party/libpng/libpng.gyp View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -3 lines 0 comments Download
M third_party/libpng/png.h View 1 2 3 4 5 6 7 8 33 chunks +2086 lines, -2569 lines 0 comments Download
M third_party/libpng/png.c View 1 2 3 4 5 6 7 8 23 chunks +3785 lines, -587 lines 0 comments Download
M third_party/libpng/pngconf.h View 1 2 3 4 5 6 7 8 2 chunks +494 lines, -1542 lines 0 comments Download
A third_party/libpng/pngdebug.h View 1 2 3 4 5 6 7 8 1 chunk +157 lines, -0 lines 0 comments Download
M third_party/libpng/pngerror.c View 1 2 3 4 5 6 7 8 11 chunks +692 lines, -156 lines 0 comments Download
M third_party/libpng/pngget.c View 1 2 3 4 5 6 7 8 19 chunks +563 lines, -330 lines 0 comments Download
A third_party/libpng/pnginfo.h View 1 2 3 4 5 6 7 8 1 chunk +260 lines, -0 lines 0 comments Download
A + third_party/libpng/pnglibconf.h View 1 2 3 4 5 6 7 8 3 chunks +71 lines, -80 lines 0 comments Download
M third_party/libpng/pngmem.c View 1 2 3 4 5 6 7 8 4 chunks +147 lines, -511 lines 0 comments Download
M third_party/libpng/pngpread.c View 1 2 3 4 5 6 7 8 58 chunks +340 lines, -823 lines 0 comments Download
A third_party/libpng/pngpriv.h View 1 2 3 4 5 6 7 8 1 chunk +2006 lines, -0 lines 0 comments Download
M third_party/libpng/pngread.c View 1 2 3 4 5 6 7 8 15 chunks +3345 lines, -873 lines 0 comments Download
M third_party/libpng/pngrio.c View 1 2 3 4 5 6 7 8 6 chunks +18 lines, -80 lines 0 comments Download
M third_party/libpng/pngrtran.c View 1 2 3 4 5 6 7 8 114 chunks +2353 lines, -1719 lines 0 comments Download
M third_party/libpng/pngrutil.c View 1 2 3 4 5 6 7 8 48 chunks +2749 lines, -1674 lines 0 comments Download
M third_party/libpng/pngset.c View 1 2 3 4 5 6 7 8 13 chunks +964 lines, -593 lines 0 comments Download
A third_party/libpng/pngstruct.h View 1 2 3 4 5 6 7 8 1 chunk +489 lines, -0 lines 0 comments Download
M third_party/libpng/pngtrans.c View 1 2 3 4 5 6 7 8 21 chunks +374 lines, -232 lines 0 comments Download
M third_party/libpng/pngusr.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -448 lines 0 comments Download
M third_party/libpng/pngwio.c View 1 2 3 4 5 6 7 8 7 chunks +29 lines, -125 lines 0 comments Download
M third_party/libpng/pngwrite.c View 1 2 3 4 5 6 7 8 38 chunks +1457 lines, -720 lines 0 comments Download
M third_party/libpng/pngwtran.c View 1 2 3 4 5 6 7 8 28 chunks +140 lines, -85 lines 0 comments Download
M third_party/libpng/pngwutil.c View 1 2 3 4 5 6 7 8 71 chunks +1326 lines, -1135 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 2 3 4 5 6 7 8 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dominik Grewe
PTAL. I've modified the macros in pnglibconf.h so that all tests are working. I'm not ...
7 years, 4 months ago (2013-08-21 16:47:08 UTC) #1
aedla
https://codereview.chromium.org/23271006/diff/27008/third_party/libpng/pnglibconf.h File third_party/libpng/pnglibconf.h (right): https://codereview.chromium.org/23271006/diff/27008/third_party/libpng/pnglibconf.h#newcode39 third_party/libpng/pnglibconf.h:39: I think we should also define PNG_SAFE_LIMITS_SUPPORTED. This limits ...
7 years, 3 months ago (2013-08-26 16:02:31 UTC) #2
Dominik Grewe
https://codereview.chromium.org/23271006/diff/27008/third_party/libpng/pnglibconf.h File third_party/libpng/pnglibconf.h (right): https://codereview.chromium.org/23271006/diff/27008/third_party/libpng/pnglibconf.h#newcode39 third_party/libpng/pnglibconf.h:39: On 2013/08/26 16:02:31, aedla wrote: > I think we ...
7 years, 3 months ago (2013-08-27 10:36:19 UTC) #3
Dominik Grewe
Could you please have another look at the patch? There were some issues with the ...
7 years, 3 months ago (2013-09-10 15:11:17 UTC) #4
palmer
LGTM on the general principle of updating to latest stable. Jüri, could you please look ...
7 years, 3 months ago (2013-09-12 23:16:47 UTC) #5
aedla
LGTM on security.
7 years, 3 months ago (2013-09-13 09:02:00 UTC) #6
Dominik Grewe
Thanks everyone!
7 years, 3 months ago (2013-09-13 09:23:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/23271006/221001
7 years, 3 months ago (2013-09-13 09:23:18 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=25320
7 years, 3 months ago (2013-09-13 09:35:14 UTC) #9
Dominik Grewe
I forgot to add an owner of third_party/, sorry. Darin, can you please have a ...
7 years, 3 months ago (2013-09-13 09:48:14 UTC) #10
darin (slow to review)
LGTM
7 years, 3 months ago (2013-09-23 19:07:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/23271006/221001
7 years, 3 months ago (2013-09-23 19:28:30 UTC) #12
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 02:39:57 UTC) #13
Message was sent while issue was closed. 
Change committed as 224858

Powered by Google App Engine
This is Rietveld 408576698