GCP2.0 Device: Adding advanced printing.

GCP2.0 Device: Adding advanced printing.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218380

[maksymb, 2013-08-17 00:44:46]

Please take a look at my CL

[Vitaly Buka (NO REVIEWS), 2013-08-17 00:56:02]

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
File cloud_print/gcp20/prototype/print_job_handler.cc (right):

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/print_job_handler.cc:21: const int kDraftExpiration
= 10;  // in seconds
kDraftExpiration -> kDraftExpirationSec etc.

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
File cloud_print/gcp20/prototype/print_job_handler.h (right):

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/print_job_handler.h:48: int* expires_in_out,
int-> base::TimeDelta

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/print_job_handler.h:84: base::TimeDelta
GetJobExpiration(const std::string& id) const;
base::TimeDelta -> base::Time

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
File cloud_print/gcp20/prototype/privet_http_server.cc (right):

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/privet_http_server.cc:293: int expires_in = 0;
base::Time expires 
base::TimeDelta error_timeout

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/privet_http_server.cc:344: // Call delegate
same

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
File cloud_print/gcp20/prototype/privet_http_server.h (right):

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/privet_http_server.h:105: int* error_timeout,
int -> base::TimeDelta

[Vitaly Buka (NO REVIEWS), 2013-08-17 01:00:46]

lgtm

please fix timeout types or create todo to fix this in new CL

[maksymb, 2013-08-17 01:13:47]

TODOs added

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
File cloud_print/gcp20/prototype/print_job_handler.cc (right):

https://codereview.chromium.org/23271004/diff/7002/cloud_print/gcp20/prototyp...
cloud_print/gcp20/prototype/print_job_handler.cc:21: const int kDraftExpiration
= 10;  // in seconds
On 2013/08/17 00:56:02, Vitaly Buka wrote:
> kDraftExpiration -> kDraftExpirationSec etc.

Done.

[commit-bot: I haz the power, 2013-08-19 04:24:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maksymb@chromium.org/23271004/21001

[commit-bot: I haz the power, 2013-08-19 04:24:55]

Failed to apply patch for cloud_print/gcp20/prototype/local_print_job.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: cloud_print/gcp20/prototype/local_print_job.cc
  |diff --git a/cloud_print/gcp20/prototype/local_print_job.cc
b/cloud_print/gcp20/prototype/local_print_job.cc
  |index
b795c30f42ae2e2b3b641e5d1f0d1f81e54bc778..cafdecf140721040f0cdd16780a7b22d24fcb69e
100644
  |--- a/cloud_print/gcp20/prototype/local_print_job.cc
  |+++ b/cloud_print/gcp20/prototype/local_print_job.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       cloud_print/gcp20/prototype/local_print_job.cc
Index: cloud_print/gcp20/prototype/local_print_job.cc
diff --git a/cloud_print/gcp20/prototype/local_print_job.cc
b/cloud_print/gcp20/prototype/local_print_job.cc
index
b795c30f42ae2e2b3b641e5d1f0d1f81e54bc778..cafdecf140721040f0cdd16780a7b22d24fcb69e
100644
--- a/cloud_print/gcp20/prototype/local_print_job.cc
+++ b/cloud_print/gcp20/prototype/local_print_job.cc
@@ -10,3 +10,9 @@ LocalPrintJob::LocalPrintJob() : offline(false) {
 LocalPrintJob::~LocalPrintJob() {
 }
 
+LocalPrintJob::Info::Info() : state(STATE_DRAFT), expires_in(-1) {
+}
+
+LocalPrintJob::Info::~Info() {
+}
+

[commit-bot: I haz the power, 2013-08-19 15:33:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maksymb@chromium.org/23271004/21001

[commit-bot: I haz the power, 2013-08-20 00:50:06]

Change committed as 218380