Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: components/browser_watcher/BUILD.gn

Issue 2327043002: A simple minidump writer for postmortem stability reports. (Closed)
Patch Set: Address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/BUILD.gn
diff --git a/components/browser_watcher/BUILD.gn b/components/browser_watcher/BUILD.gn
index 883daece472ef5a8e9064c040f27a064d18a4e42..709775cd6c13c48a1006fac8264c1390aaa39c3c 100644
--- a/components/browser_watcher/BUILD.gn
+++ b/components/browser_watcher/BUILD.gn
@@ -2,6 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//third_party/protobuf/proto_library.gni")
+
+proto_library("stability_report_proto") {
+ sources = [
+ "stability_report.proto",
+ ]
+}
+
static_library("browser_watcher") {
# This is a separate lib to minimize the dependencies for its
# hosting binary "chrome_watcher.dll".
@@ -33,12 +41,28 @@ static_library("browser_watcher_client") {
]
}
+static_library("postmortem_minidump_writer") {
+ # TODO(manzagop): remove this lib once CrashPad writes the minidumps.
scottmg 2016/09/13 18:07:43 nit; CrashPad -> Crashpad, and elsewhere.
manzagop (departed) 2016/09/13 21:19:41 Done.
+ sources = [
+ "postmortem_minidump_writer.h",
+ "postmortem_minidump_writer_win.cc",
+ ]
+ deps = [
+ ":stability_report_proto",
+ "//base",
+ "//third_party/crashpad/crashpad/client",
+ "//third_party/crashpad/crashpad/minidump",
+ "//third_party/crashpad/crashpad/util",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
"endsession_watcher_window_win_unittest.cc",
"exit_code_watcher_win_unittest.cc",
"exit_funnel_win_unittest.cc",
+ "postmortem_minidump_writer_win_unittest.cc",
"watcher_client_win_unittest.cc",
"watcher_metrics_provider_win_unittest.cc",
"window_hang_monitor_win_unittest.cc",
@@ -47,8 +71,15 @@ source_set("unit_tests") {
deps = [
":browser_watcher",
":browser_watcher_client",
+ ":postmortem_minidump_writer",
+ ":stability_report_proto",
"//base",
"//base/test:test_support",
"//testing/gtest",
+ "//third_party/crashpad/crashpad/client",
+
+ # TODO(manzagop): remove this lib once CrashPad writes the minidumps.
+ "//third_party/crashpad/crashpad/compat",
+ "//third_party/crashpad/crashpad/minidump",
]
}
« no previous file with comments | « no previous file | components/browser_watcher/DEPS » ('j') | components/browser_watcher/postmortem_minidump_writer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698