chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java - Issue 23264020: Move Android to use new Popup Blocker API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

Issue 23264020: Move Android to use new Popup Blocker API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/chrome_web_contents_delegate_android.h » ('j') | chrome/browser/android/chrome_web_contents_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

index 546f3029af7bfe08b3f6d60e6bde948e8f5e74f6..f1c0355f48e8c154fe9e801b594bf299439f9bae 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

@@ -26,6 +26,12 @@ public class ChromeWebContentsDelegateAndroid extends WebContentsDelegateAndroid

public void onFindMatchRectsAvailable(FindMatchRectsDetails result) {

}

+ @CalledByNative

+ public boolean addNewContents(int nativeSourceWebContents, int nativeWebContents,

+ int disposition, Rect initialPosition, boolean userGesture) {

+ return false;

+ }

// Helper functions used to create types that are part of the public interface

@CalledByNative

private static Rect createRect(int x, int y, int right, int bottom) {