Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects.cc

Issue 23262002: Store copied value rather than the original double. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-convert-function-to-double.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2213 matching lines...) Expand 10 before | Expand all | Expand 10 after
2224 new_value->AllocateNewStorageFor(heap, representation); 2224 new_value->AllocateNewStorageFor(heap, representation);
2225 if (!maybe_storage->To(&storage)) return maybe_storage; 2225 if (!maybe_storage->To(&storage)) return maybe_storage;
2226 2226
2227 // Update pointers to commit changes. 2227 // Update pointers to commit changes.
2228 // Object points to the new map. 2228 // Object points to the new map.
2229 new_map->set_unused_property_fields(new_unused_property_fields); 2229 new_map->set_unused_property_fields(new_unused_property_fields);
2230 set_map(new_map); 2230 set_map(new_map);
2231 if (new_properties != NULL) { 2231 if (new_properties != NULL) {
2232 set_properties(new_properties); 2232 set_properties(new_properties);
2233 } 2233 }
2234 FastPropertyAtPut(index, new_value); 2234 FastPropertyAtPut(index, storage);
2235 return new_value; 2235 return new_value;
2236 } 2236 }
2237 2237
2238 2238
2239 const char* Representation::Mnemonic() const { 2239 const char* Representation::Mnemonic() const {
2240 switch (kind_) { 2240 switch (kind_) {
2241 case kNone: return "v"; 2241 case kNone: return "v";
2242 case kTagged: return "t"; 2242 case kTagged: return "t";
2243 case kSmi: return "s"; 2243 case kSmi: return "s";
2244 case kDouble: return "d"; 2244 case kDouble: return "d";
(...skipping 13732 matching lines...) Expand 10 before | Expand all | Expand 10 after
15977 #define ERROR_MESSAGES_TEXTS(C, T) T, 15977 #define ERROR_MESSAGES_TEXTS(C, T) T,
15978 static const char* error_messages_[] = { 15978 static const char* error_messages_[] = {
15979 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 15979 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
15980 }; 15980 };
15981 #undef ERROR_MESSAGES_TEXTS 15981 #undef ERROR_MESSAGES_TEXTS
15982 return error_messages_[reason]; 15982 return error_messages_[reason];
15983 } 15983 }
15984 15984
15985 15985
15986 } } // namespace v8::internal 15986 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-convert-function-to-double.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698