Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: blimp/client/core/contents/navigation_feature.cc

Issue 2325893002: [blimp] Add support for having multiple tabs (Closed)
Patch Set: Add tablet and non-blimp support Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/navigation_feature.cc
diff --git a/blimp/client/core/contents/navigation_feature.cc b/blimp/client/core/contents/navigation_feature.cc
index 2660441f13c6bacb6cf570ecad2c7ea6d8cd3941..965b9a819f1773f382de3e4881d6d49df0761efa 100644
--- a/blimp/client/core/contents/navigation_feature.cc
+++ b/blimp/client/core/contents/navigation_feature.cc
@@ -94,7 +94,13 @@ void NavigationFeature::ProcessMessage(
const NavigationMessage& navigation_message = message->navigation();
NavigationFeatureDelegate* delegate = FindDelegate(tab_id);
- DCHECK(delegate) << "NavigationFeatureDelegate not found for tab " << tab_id;
+ if (!delegate) {
+ VLOG(1) << "NavigationFeatureDelegate not found for " << tab_id
+ << ". Ignoring.";
+ callback.Run(net::OK);
+ return;
+ }
+
switch (navigation_message.type()) {
case NavigationMessage::NAVIGATION_STATE_CHANGED: {
const NavigationStateChangeMessage& details =

Powered by Google App Engine
This is Rietveld 408576698