Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: blimp/client/core/contents/blimp_contents_manager.cc

Issue 2325893002: [blimp] Add support for having multiple tabs (Closed)
Patch Set: Add tablet and non-blimp support Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_manager.cc
diff --git a/blimp/client/core/contents/blimp_contents_manager.cc b/blimp/client/core/contents/blimp_contents_manager.cc
index 52214d4e6838650b6f798e42033feeb566f01b35..3bf40972fa61917afa087dcb650f8e6867bd7edf 100644
--- a/blimp/client/core/contents/blimp_contents_manager.cc
+++ b/blimp/client/core/contents/blimp_contents_manager.cc
@@ -14,10 +14,6 @@
#include "blimp/client/core/render_widget/render_widget_feature.h"
#include "blimp/client/public/contents/blimp_contents_observer.h"
-namespace {
-const int kDummyTabId = 0;
-}
-
namespace blimp {
namespace client {
@@ -102,10 +98,7 @@ BlimpContentsImpl* BlimpContentsManager::GetBlimpContents(int id) {
}
int BlimpContentsManager::CreateBlimpContentsId() {
- // TODO(mlliu): currently, Blimp only supports a single tab, so returning a
- // dummy tab id. Need to return real case id when Blimp supports multiple
- // tabs.
- return kDummyTabId;
+ return next_blimp_contents_id_++;
}
void BlimpContentsManager::EraseObserverFromMap(int id) {
« no previous file with comments | « blimp/client/core/contents/blimp_contents_manager.h ('k') | blimp/client/core/contents/blimp_contents_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698