Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2325893002: [blimp] Add support for having multiple tabs (Closed)
Patch Set: Add tablet and non-blimp support Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc
diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
index 31c5f866a23ff1b97f1ffca84dbad6e39fca30a8..82345d8341c8e998b1377d6383616848b9b58ad1 100644
--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc
+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc
@@ -27,7 +27,7 @@ namespace {
const char kExampleURL[] = "https://www.example.com/";
const char kOtherExampleURL[] = "https://www.otherexample.com/";
-const int kDummyTabId = 0;
+const int kDummyBlimpContentsId = 0;
class MockBlimpContentsObserver : public BlimpContentsObserver {
public:
@@ -75,9 +75,9 @@ TEST_F(BlimpContentsImplTest, LoadURLAndNotifyObservers) {
RenderWidgetFeature render_widget_feature;
BlimpCompositorDependencies compositor_deps(
base::MakeUnique<MockCompositorDependencies>());
- BlimpContentsImpl blimp_contents(kDummyTabId, window_, &compositor_deps,
- &ime_feature, &navigation_feature,
- &render_widget_feature, nullptr);
+ BlimpContentsImpl blimp_contents(
+ kDummyBlimpContentsId, window_, &compositor_deps, &ime_feature,
+ &navigation_feature, &render_widget_feature, nullptr);
BlimpNavigationControllerImpl& navigation_controller =
blimp_contents.GetNavigationController();
@@ -114,7 +114,7 @@ TEST_F(BlimpContentsImplTest, SetSizeAndScaleThroughTabControlFeature) {
BlimpCompositorDependencies compositor_deps(
base::MakeUnique<MockCompositorDependencies>());
BlimpContentsImpl blimp_contents(
- kDummyTabId, window_, &compositor_deps, &ime_feature, nullptr,
+ kDummyBlimpContentsId, window_, &compositor_deps, &ime_feature, nullptr,
&render_widget_feature, &tab_control_feature);
EXPECT_CALL(tab_control_feature,
« no previous file with comments | « blimp/client/core/contents/blimp_contents_impl.cc ('k') | blimp/client/core/contents/blimp_contents_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698