Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: blimp/client/core/contents/tab_control_feature.cc

Issue 2325893002: [blimp] Add support for having multiple tabs (Closed)
Patch Set: Add tablet and non-blimp support Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/tab_control_feature.h" 5 #include "blimp/client/core/contents/tab_control_feature.h"
6 6
7 #include "blimp/common/create_blimp_message.h" 7 #include "blimp/common/create_blimp_message.h"
8 #include "blimp/common/proto/blimp_message.pb.h" 8 #include "blimp/common/proto/blimp_message.pb.h"
9 #include "blimp/common/proto/tab_control.pb.h" 9 #include "blimp/common/proto/tab_control.pb.h"
10 #include "blimp/net/blimp_message_processor.h" 10 #include "blimp/net/blimp_message_processor.h"
(...skipping 25 matching lines...) Expand all
36 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a 36 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a
37 // CompletionCallback to return before sending future size updates. 37 // CompletionCallback to return before sending future size updates.
38 outgoing_message_processor_->ProcessMessage(std::move(message), 38 outgoing_message_processor_->ProcessMessage(std::move(message),
39 net::CompletionCallback()); 39 net::CompletionCallback());
40 } 40 }
41 41
42 void TabControlFeature::CreateTab(int tab_id) { 42 void TabControlFeature::CreateTab(int tab_id) {
43 TabControlMessage* tab_control; 43 TabControlMessage* tab_control;
44 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control); 44 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
45 tab_control->mutable_create_tab(); 45 tab_control->mutable_create_tab();
46 message->set_target_tab_id(tab_id);
46 outgoing_message_processor_->ProcessMessage(std::move(message), 47 outgoing_message_processor_->ProcessMessage(std::move(message),
47 net::CompletionCallback()); 48 net::CompletionCallback());
48 } 49 }
49 50
50 void TabControlFeature::CloseTab(int tab_id) { 51 void TabControlFeature::CloseTab(int tab_id) {
51 TabControlMessage* tab_control; 52 TabControlMessage* tab_control;
52 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control); 53 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&tab_control);
53 tab_control->mutable_close_tab(); 54 tab_control->mutable_close_tab();
55 message->set_target_tab_id(tab_id);
54 outgoing_message_processor_->ProcessMessage(std::move(message), 56 outgoing_message_processor_->ProcessMessage(std::move(message),
55 net::CompletionCallback()); 57 net::CompletionCallback());
56 } 58 }
57 59
58 void TabControlFeature::ProcessMessage( 60 void TabControlFeature::ProcessMessage(
59 std::unique_ptr<BlimpMessage> message, 61 std::unique_ptr<BlimpMessage> message,
60 const net::CompletionCallback& callback) { 62 const net::CompletionCallback& callback) {
61 DCHECK(!callback.is_null()); 63 DCHECK(!callback.is_null());
62 callback.Run(net::OK); 64 callback.Run(net::OK);
63 65
64 NOTIMPLEMENTED(); 66 NOTIMPLEMENTED();
65 } 67 }
66 68
67 } // namespace client 69 } // namespace client
68 } // namespace blimp 70 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/client/core/contents/navigation_feature.cc ('k') | blimp/engine/session/blimp_engine_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698