drive: Move RefreshDirectory from ResourceMetadata to ChangeListLoader

chrome/browser/chromeos/drive/change_list_processor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/change_list_processor.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/drive/drive.pb.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/drive/resource_metadata.h"
 #include "chrome/browser/chromeos/drive/test_util.h"
 #include "chrome/browser/google_apis/drive_api_parser.h"
 #include "chrome/browser/google_apis/gdata_wapi_parser.h"
 #include "chrome/browser/google_apis/test_util.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace drive {
 namespace internal {
 
 namespace {
 
 const int64 kBaseResourceListChangestamp = 123;
 const char kBaseResourceListFile[] = "gdata/root_feed.json";
+const char kRootId[] = "fake_root";
 
 enum FileOrDirectory {
   FILE,
   DIRECTORY,
 };
 
 struct EntryExpectation {
   std::string path;
   std::string id;
   std::string parent_id;
@@ skipping 24 matching lines @@
                 test_data_path))));
     return changes.Pass();
   }
 
   // Applies the |changes| to |metadata_| as a full resource list of changestamp
   // |kBaseResourceListChangestamp|.
   void ApplyFullResourceList(ScopedVector<ChangeList> changes) {
     scoped_ptr<google_apis::AboutResource> about_resource(
         new google_apis::AboutResource);
     about_resource->set_largest_change_id(kBaseResourceListChangestamp);
-    about_resource->set_root_folder_id("fake_root");
+    about_resource->set_root_folder_id(kRootId);
 
     ChangeListProcessor processor(metadata_.get());
     processor.Apply(about_resource.Pass(),
                     changes.Pass(),
                     false /* is_delta_update */);
   }
 
   // Applies the |changes| to |metadata_| as a delta update. Delta changelists
   // should contain their changestamp in themselves.
   std::set<base::FilePath> ApplyChangeList(ScopedVector<ChangeList> changes) {
@@ skipping 23 matching lines @@
 };
 
 }  // namespace
 
 TEST_F(ChangeListProcessorTest, ApplyFullResourceList) {
   ApplyFullResourceList(ParseChangeList(kBaseResourceListFile));
 
   const EntryExpectation kExpected[] = {
       // Root files
       {"drive/root",
-          "fake_root", util::kDriveGrandRootSpecialResourceId, DIRECTORY},
+          kRootId, util::kDriveGrandRootSpecialResourceId, DIRECTORY},
       {"drive/root/File 1.txt",
-          "file:2_file_resource_id", "fake_root", FILE},
+          "file:2_file_resource_id", kRootId, FILE},
       {"drive/root/Slash \xE2\x88\x95 in file 1.txt",
-          "file:slash_file_resource_id", "fake_root", FILE},
+          "file:slash_file_resource_id", kRootId, FILE},
       {"drive/root/Document 1 excludeDir-test.gdoc",
-          "document:5_document_resource_id", "fake_root", FILE},
+          "document:5_document_resource_id", kRootId, FILE},
       // Subdirectory files
       {"drive/root/Directory 1",
-          "folder:1_folder_resource_id", "fake_root", DIRECTORY},
+          "folder:1_folder_resource_id", kRootId, DIRECTORY},
       {"drive/root/Directory 1/SubDirectory File 1.txt",
           "file:subdirectory_file_1_id", "folder:1_folder_resource_id", FILE},
       {"drive/root/Directory 1/Shared To The Account Owner.txt",
           "file:subdirectory_unowned_file_1_id",
           "folder:1_folder_resource_id", FILE},
       {"drive/root/Directory 2 excludeDir-test",
-          "folder:sub_dir_folder_2_self_link", "fake_root", DIRECTORY},
+          "folder:sub_dir_folder_2_self_link", kRootId, DIRECTORY},
       {"drive/root/Slash \xE2\x88\x95 in directory",
-          "folder:slash_dir_folder_resource_id", "fake_root", DIRECTORY},
+          "folder:slash_dir_folder_resource_id", kRootId, DIRECTORY},
       {"drive/root/Slash \xE2\x88\x95 in directory/Slash SubDir File.txt",
           "file:slash_subdir_file",
           "folder:slash_dir_folder_resource_id", FILE},
       // Deeper
       {"drive/root/Directory 1/Sub Directory Folder",
           "folder:sub_dir_folder_resource_id",
           "folder:1_folder_resource_id", DIRECTORY},
       {"drive/root/Directory 1/Sub Directory Folder/Sub Sub Directory Folder",
           "folder:sub_sub_directory_folder_id",
           "folder:sub_dir_folder_resource_id", DIRECTORY},
@@ skipping 16 matching lines @@
 }
 
 TEST_F(ChangeListProcessorTest, DeltaFileAddedInNewDirectory) {
   const char kTestJson[] =
       "gdata/delta_file_added_in_new_directory.json";
 
   ChangeListProcessor::ResourceEntryMap entry_map;
   ChangeListProcessor::ConvertToMap(
       ParseChangeList(kTestJson), &entry_map, NULL);
 
-  const std::string kRootId("fake_root");
   const std::string kNewFolderId("folder:new_folder_resource_id");
   const std::string kNewFileId("document:file_added_in_new_dir_id");
 
   // Check the content of parsed ResourceEntryMap.
   EXPECT_EQ(2U, entry_map.size());
   EXPECT_TRUE(entry_map.count(kNewFolderId));
   EXPECT_TRUE(entry_map.count(kNewFileId));
   EXPECT_EQ(kRootId, entry_map[kNewFolderId].parent_local_id());
   EXPECT_EQ(kNewFolderId, entry_map[kNewFileId].parent_local_id());
   EXPECT_TRUE(entry_map[kNewFolderId].file_info().is_directory());
@@ skipping 61 matching lines @@
 }
 
 TEST_F(ChangeListProcessorTest, DeltaFileMovedFromDirectoryToRoot) {
   const char kTestJson[] =
       "gdata/delta_file_moved_from_directory_to_root.json";
 
   ChangeListProcessor::ResourceEntryMap entry_map;
   ChangeListProcessor::ConvertToMap(
       ParseChangeList(kTestJson), &entry_map, NULL);
 
-  const std::string kRootId("fake_root");
   const std::string kMovedId("file:subdirectory_file_1_id");
   const std::string kSrcId("folder:1_folder_resource_id");
 
   // Check the content of parsed ResourceEntryMap.
   EXPECT_EQ(2U, entry_map.size());
   EXPECT_TRUE(entry_map.count(kMovedId));
   EXPECT_TRUE(entry_map.count(kSrcId));
   EXPECT_EQ(kRootId, entry_map[kMovedId].parent_local_id());
 
   // Apply the changelist and check the effect.
@@ skipping 15 matching lines @@
 }
 
 TEST_F(ChangeListProcessorTest, DeltaFileRenamedInDirectory) {
   const char kTestJson[] =
       "gdata/delta_file_renamed_in_directory.json";
 
   ChangeListProcessor::ResourceEntryMap entry_map;
   ChangeListProcessor::ConvertToMap(
       ParseChangeList(kTestJson), &entry_map, NULL);
 
-  const std::string kRootId("fake_root");
   const std::string kRenamedId("file:subdirectory_file_1_id");
   const std::string kParentId("folder:1_folder_resource_id");
 
   // Check the content of parsed ResourceEntryMap.
   EXPECT_EQ(2U, entry_map.size());
   EXPECT_TRUE(entry_map.count(kRenamedId));
   EXPECT_TRUE(entry_map.count(kParentId));
   EXPECT_EQ(kParentId, entry_map[kRenamedId].parent_local_id());
   EXPECT_EQ("New SubDirectory File 1.txt", entry_map[kRenamedId].title());
 
@@ skipping 15 matching lines @@
   EXPECT_TRUE(changed_dirs.count(
       base::FilePath::FromUTF8Unsafe("drive/root/Directory 1")));
 }
 
 TEST_F(ChangeListProcessorTest, DeltaAddAndDeleteFileInRoot) {
   const char kTestJsonAdd[] =
       "gdata/delta_file_added_in_root.json";
   const char kTestJsonDelete[] =
       "gdata/delta_file_deleted_in_root.json";
 
-  const std::string kParentId("fake_root");
+  const std::string kParentId(kRootId);
   const std::string kFileId("document:added_in_root_id");
 
   ChangeListProcessor::ResourceEntryMap entry_map;
 
   // Check the content of kTestJsonAdd.
   ChangeListProcessor::ConvertToMap(
       ParseChangeList(kTestJsonAdd), &entry_map, NULL);
   EXPECT_EQ(1U, entry_map.size());
   EXPECT_TRUE(entry_map.count(kFileId));
   EXPECT_EQ(kParentId, entry_map[kFileId].parent_local_id());
@@ skipping 89 matching lines @@
   // 1) A new PDF file is added to a new directory
   // 2) but the new directory is marked "deleted" (i.e. moved to Trash)
   // Hence, the PDF file should be just ignored.
   const char kTestJson[] =
       "gdata/delta_file_added_in_new_but_deleted_directory.json";
 
   ChangeListProcessor::ResourceEntryMap entry_map;
   ChangeListProcessor::ConvertToMap(
       ParseChangeList(kTestJson), &entry_map, NULL);
 
-  const std::string kRootId("fake_root");
   const std::string kDirId("folder:new_folder_resource_id");
   const std::string kFileId("pdf:file_added_in_deleted_dir_id");
 
   // Check the content of parsed ResourceEntryMap.
   EXPECT_EQ(2U, entry_map.size());
   EXPECT_TRUE(entry_map.count(kDirId));
   EXPECT_TRUE(entry_map.count(kFileId));
   EXPECT_EQ(kDirId, entry_map[kFileId].parent_local_id());
   EXPECT_TRUE(entry_map[kDirId].deleted());
 
   // Apply the changelist and check the effect.
   ApplyFullResourceList(ParseChangeList(kBaseResourceListFile));
   std::set<base::FilePath> changed_dirs =
       ApplyChangeList(ParseChangeList(kTestJson));
 
   // The value is written in kTestJson.
   EXPECT_EQ(16730, metadata_->GetLargestChangestamp());
   EXPECT_FALSE(GetResourceEntry("drive/root/New Directory/new_pdf_file.pdf"));
 
   EXPECT_TRUE(changed_dirs.empty());
 }
 
+TEST_F(ChangeListProcessorTest, RefreshDirectory) {
+  // Prepare metadata.
+  ApplyFullResourceList(ParseChangeList(kBaseResourceListFile));
+
+  // Create a map.
+  ChangeListProcessor::ResourceEntryMap entry_map;
+
+  // Add a new file to the map.
+  ResourceEntry new_file;
+  new_file.set_title("new_file");
+  new_file.set_resource_id("new_file_id");
+  new_file.set_parent_local_id(kRootId);
+  entry_map["new_file_id"] = new_file;
+
+  // Add "Directory 1" to the map with a new name.
+  ResourceEntry dir1;
+  EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryByPath(
+      util::GetDriveMyDriveRootPath().AppendASCII("Directory 1"), &dir1));
+  dir1.set_title(dir1.title() + " (renamed)");
+  entry_map[dir1.resource_id()] = dir1;
+
+  // Update the directory with the map.
+  const int64 kNewChangestamp = 12345;
+  base::FilePath file_path;
+  EXPECT_EQ(FILE_ERROR_OK, ChangeListProcessor::RefreshDirectory(
+      metadata_.get(),
+      DirectoryFetchInfo(kRootId, kNewChangestamp),
+      entry_map,
+      &file_path));
+  EXPECT_EQ(util::GetDriveMyDriveRootPath().value(), file_path.value());
+
+  // The new changestamp should be set.
+  ResourceEntry entry;
+  EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryByPath(
+      util::GetDriveMyDriveRootPath(), &entry));
+  EXPECT_EQ(kNewChangestamp, entry.directory_specific_info().changestamp());
+
+  // "new_file" should be added.
+  EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryByPath(
+      util::GetDriveMyDriveRootPath().AppendASCII(new_file.title()), &entry));
+
+  // "Directory 1" should be renamed.
+  EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryByPath(
+      util::GetDriveMyDriveRootPath().AppendASCII(dir1.title()), &entry));
+}
+
+TEST_F(ChangeListProcessorTest, RefreshDirectory_WrongParentId) {
+  // Prepare metadata.
+  ApplyFullResourceList(ParseChangeList(kBaseResourceListFile));
+
+  // Create a map and add a new file to it.
+  ChangeListProcessor::ResourceEntryMap entry_map;
+  ResourceEntry new_file;
+  new_file.set_title("new_file");
+  new_file.set_resource_id("new_file_id");
+  // This entry should not be added because the parent ID does not match.
+  new_file.set_parent_local_id("some-random-resource-id");
+  entry_map["new_file_id"] = new_file;
+
+  // Update the directory with the map.
+  const int64 kNewChangestamp = 12345;
+  base::FilePath file_path;
+  EXPECT_EQ(FILE_ERROR_OK, ChangeListProcessor::RefreshDirectory(
+      metadata_.get(),
+      DirectoryFetchInfo(kRootId, kNewChangestamp),
+      entry_map,
+      &file_path));
+  EXPECT_EQ(util::GetDriveMyDriveRootPath().value(), file_path.value());
+
+  // "new_file" should not be added.
+  ResourceEntry entry;
+  EXPECT_EQ(FILE_ERROR_NOT_FOUND, metadata_->GetResourceEntryByPath(
+      util::GetDriveMyDriveRootPath().AppendASCII(new_file.title()), &entry));
+}
+
 }  // namespace internal
 }  // namespace drive